Merged
Conversation
dxqb
added a commit
to dxqb/OneTrainer
that referenced
this pull request
Nov 24, 2025
Owner
|
I haven't tested the change, but it's much shorter and still readable. I usually prefer inheritance and mixins. But in this case I think it's ok to deviate from the usual style if it makes the code easier to maintain. |
Collaborator
Author
|
Thanks! It has been merged into #1034 which people have tested, so it should already be tested reasonably well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to de-duplicate identical code between models,
This PR is only model loaders, but the principle could be applied to other parts of the object model.
This PR uses class constructors, similar to C++ templates. An alternative to this way would be to use base classes and mixins, but I feel this way is cleaner and less likely to break things. Feedback welcome