Closed
Conversation
…move full data from the main json file; when a venue map pin is clicked, dynamically load the full details for the venue at that point from the new individual JSON file at that point
A succession of little JS functions each try to shorten the address displayed in the map popup bubble. The reason for this approach is that it's easy to add new functions to the SHORTENERS list as and when we think of them. This does not change the data stored in the markdown files; it only changes the address displayed in the popup bubbles on the map. Note that this depends on and includes the dynamically-load-bubble-text PR at NerdyDayTrips#593 This should hopefully alleviate the problems that motivated NerdyDayTrips#558
Contributor
|
Sorry for not getting to this sooner. Is this still necessary? I did some work improving the bubbles/popups, and I think that makes this unnecessary? |
Contributor
|
Thanks again, but I don't think we need this now, but feel free to argue with me if I'm wrong :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A succession of little JS functions each try to shorten the address displayed in the map popup bubble.
The reason for this approach is that it's easy to add new functions to the SHORTENERS list as and when we think of them.
This does not change the data stored in the markdown files; it only changes the address displayed in the popup bubbles on the map.
Note that this depends on and includes the dynamically-load-bubble-text PR at #593
This should hopefully alleviate the problems that motivated #558