NeotokyoRevamp · nullsystem · Apr 28, 2024 · Jul 29, 2023 · Apr 28, 2024 · Apr 28, 2024
diff --git a/BUILD_INSTRUCTIONS.md b/BUILD_INSTRUCTIONS.md
@@ -3,6 +3,10 @@
 See instructions for your platform:
 
 ## Compiling
+When following the instructions for Windows, VS2022 is now the minimum requirement so the instructions to
+download/install VS2013 is no longer needed and replaced by just downloading/installing VS2022 instead. Make sure
+to at least include the C++ Development tools during VS2022 installation.
+
 https://developer.valvesoftware.com/wiki/Source_SDK_2013
 
 ## Steam mod setup

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -70,8 +70,7 @@ In shared code, clientside code can be differentiated with CLIENT_DLL, vs. serve
 
 No big restrictions on general code format, just try to more or less match the other SDK code style.
 
-* C++11, except...
-    * Use const (or #define) over constexpr; while it is a part of C++11 spec, the v120 MSVC toolset that Source targets on Windows doesn't support it natively.
+* C++11, generally within v143 MSVC toolset on Windows and GCC 13+ on Linux supports
 * Valve likes to ( space ) their arguments, especially with macros, but it's not necessary to strictly follow everywhere.
 * Tabs are preferred for indentation, to be consistent with the SDK code.
 * When using a TODO/FIXME/HACK... style comment, use the format "// NEO TODO (Your-username): Example comment." to make it easier to search NEO specific todos/fixmes (opposed to Valve ones), and at a glance figure out who has written them.

diff --git a/mp/game/neo/maps/.gitignore b/mp/game/neo/maps/.gitignore
@@ -0,0 +1 @@
+*.bsp
diff --git a/mp/src/devtools/bin/vpc.exe b/mp/src/devtools/bin/vpc.exe
diff --git a/mp/src/game/client/c_baseanimating.h b/mp/src/game/client/c_baseanimating.h
@@ -79,7 +79,7 @@ class CAttachmentData
 	QAngle	m_angRotation;
 	Vector	m_vOriginVelocity;
 	int		m_nLastFramecount : 31;
-	int		m_bAnglesComputed : 1;
+	unsigned int m_bAnglesComputed : 1;
 };
 
 

diff --git a/mp/src/game/client/c_baseentity.cpp b/mp/src/game/client/c_baseentity.cpp
@@ -4751,7 +4751,7 @@ C_BaseEntity *C_BaseEntity::Instance( int iEnt )
 
 #ifdef WIN32
 #pragma warning( push )
-#include <typeinfo.h>
+#include <typeinfo>
 #pragma warning( pop )
 #endif
 

diff --git a/mp/src/game/client/hud_pdump.cpp b/mp/src/game/client/hud_pdump.cpp
@@ -22,7 +22,7 @@ static CPDumpPanel *g_pPDumpPanel = NULL;
 //  retaining our own warning setup...ywb
 #ifdef WIN32
 #pragma warning( push )
-#include <typeinfo.h>
+#include <typeinfo>
 #pragma warning( pop )
 #endif
 
@@ -439,4 +439,4 @@ void CPDumpPanel::Paint()
 	surface()->DrawPrintText( szconverted, wcslen( szconverted ) );
 
 	y += fonttall;
-}
+}
diff --git a/mp/src/game/client/neo/ui/neo_hud_round_state.cpp b/mp/src/game/client/neo/ui/neo_hud_round_state.cpp
@@ -8,6 +8,7 @@
 #include <vgui/ISurface.h>
 
 #include "neo_gamerules.h"
+#include <initializer_list>
 
 #include <vgui_controls/ImagePanel.h>
 

diff --git a/mp/src/game/client/particlemgr.h b/mp/src/game/client/particlemgr.h
@@ -120,7 +120,7 @@ entities. Each one is useful under different conditions.
 #include "utllinkedlist.h"
 #include "utldict.h"
 #ifdef WIN32
-#include <typeinfo.h>
+#include <typeinfo>
 #else
 #include <typeinfo>
 #endif

diff --git a/mp/src/game/client/physics_main_client.cpp b/mp/src/game/client/physics_main_client.cpp
@@ -7,7 +7,7 @@
 #include "cbase.h"
 #include "c_baseentity.h"
 #ifdef WIN32
-#include <typeinfo.h>
+#include <typeinfo>
 #endif
 #include "tier0/vprof.h"
 
@@ -341,4 +341,4 @@ void C_BaseEntity::PhysicsDispatchThink( BASEPTR thinkFunc )
 			}
 		}
 	}
-}
+}
diff --git a/mp/src/game/server/physics_main.cpp b/mp/src/game/server/physics_main.cpp
@@ -8,7 +8,7 @@
 
 #include "cbase.h"
 #ifdef _WIN32
-#include "typeinfo.h"
+#include <typeinfo>
 // BUGBUG: typeinfo stomps some of the warning settings (in yvals.h)
 #pragma warning(disable:4244)
 #elif POSIX

diff --git a/mp/src/game/shared/neo/neo_playeranimstate.h b/mp/src/game/shared/neo/neo_playeranimstate.h
@@ -49,6 +49,7 @@ class INEOPlayerAnimStateHelpers
 public:
 	virtual CBaseCombatWeapon* NEOAnim_GetActiveWeapon() = 0;
 	virtual bool NEOAnim_CanMove() = 0;
+	virtual ~INEOPlayerAnimStateHelpers() {}
 };
 
 INEOPlayerAnimState *CreatePlayerAnimState(CBaseAnimatingOverlay *pEntity,
@@ -60,4 +61,4 @@ INEOPlayerAnimStateHelpers* CreateAnimStateHelpers(CNEO_Player* pPlayer);
 // to the local player if he's the one being watched.
 extern ConVar cl_showanimstate;
 
-#endif // NEO_PLAYERANIMSTATE_H
+#endif // NEO_PLAYERANIMSTATE_H
diff --git a/mp/src/game/shared/neo/neo_shot_manipulator.cpp b/mp/src/game/shared/neo/neo_shot_manipulator.cpp
@@ -1,10 +1,7 @@
 #include "cbase.h"
 #include "neo_shot_manipulator.h"
 #include "weapon_neobasecombatweapon.h"
-
-#ifdef LINUX
 #include <initializer_list>
-#endif
 
 // memdbgon must be the last include file in a .cpp file!!!
 #include "tier0/memdbgon.h"

diff --git a/mp/src/game/shared/neo/weapons/weapon_neobasecombatweapon.cpp b/mp/src/game/shared/neo/weapons/weapon_neobasecombatweapon.cpp
@@ -9,9 +9,7 @@
 
 #include "basecombatweapon_shared.h"
 
-#ifdef LINUX
 #include <initializer_list>
-#endif
 
 // memdbgon must be the last include file in a .cpp file!!!
 #include "tier0/memdbgon.h"

diff --git a/mp/src/lib/public/.gitignore b/mp/src/lib/public/.gitignore
@@ -0,0 +1 @@
+*.pdb
diff --git a/mp/src/lib/public/particles.lib b/mp/src/lib/public/particles.lib
diff --git a/mp/src/public/haptics/ihaptics.h b/mp/src/public/haptics/ihaptics.h
@@ -49,6 +49,7 @@ abstract_class IHaptics
 		IEngineVGui* newvgui,
 		ActivityList_IndexForName_t actIndexForName,
 		ActivityList_NameForIndex_t actNameForIndex) = 0;
+	virtual ~IHaptics() {}
 
 public: // Device methods
 
@@ -141,4 +142,4 @@ inline void IHaptics::ClearNavigationClass( void )
 
 extern IHaptics* haptics;
 
-#endif// HAPTICS_INTERFACE_H
+#endif// HAPTICS_INTERFACE_H
diff --git a/mp/src/public/scratchpad3d.h b/mp/src/public/scratchpad3d.h
@@ -51,7 +51,7 @@ class CScratchPad3D : public IScratchPad3D
 							m_pCachedRenderData = NULL;
 						}
 
-						~CBaseCommand()
+						virtual ~CBaseCommand()
 						{
 							ReleaseCachedRenderData();
 						}

diff --git a/mp/src/public/tier0/memalloc.h b/mp/src/public/tier0/memalloc.h
@@ -382,7 +382,7 @@ class CMemAllocAttributeAlloction
 
 	#pragma warning(disable:4290)
 	#pragma warning(push)
-	#include <typeinfo.h>
+	#include <typeinfo>
 
 	// MEM_DEBUG_CLASSNAME is opt-in.
 	// Note: typeid().name() is not threadsafe, so if the project needs to access it in multiple threads