Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Feb 26, 2025

Description

Adds an MP3 player, with the music files in the soundtrack folder of the original being available by default.

-fixes #987

@AdamTadeusz AdamTadeusz marked this pull request as draft February 26, 2025 13:49
@AdamTadeusz AdamTadeusz marked this pull request as ready for review February 26, 2025 18:09
@AdamTadeusz
Copy link
Contributor Author

when the keybind cache gets reset both keys should be reset, so probably only need to check the value of one of them and then update all the cached bindings if the first one isn't cached in retrospect

@AdamTadeusz AdamTadeusz requested a review from a team February 27, 2025 15:36
brysondev
brysondev previously approved these changes Mar 2, 2025
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one nit. Also might wanna enable console by default as well while we're at it.

@brysondev
Copy link
Contributor

Oh also as a question/general feedback: is there any way to double click a song to have it play instead of spamming "next" or "previous" to get the sound you want?

brysondev
brysondev previously approved these changes Mar 2, 2025
brysondev
brysondev previously approved these changes Mar 3, 2025
@AdamTadeusz AdamTadeusz marked this pull request as draft April 22, 2025 14:07
@AdamTadeusz AdamTadeusz marked this pull request as ready for review April 22, 2025 14:17
@AdamTadeusz AdamTadeusz requested a review from brysondev April 22, 2025 14:17
@AdamTadeusz AdamTadeusz added this to the QoL milestone Apr 23, 2025
@AdamTadeusz AdamTadeusz requested a review from a team May 13, 2025 10:21
@AdamTadeusz AdamTadeusz marked this pull request as draft May 30, 2025 16:07
@AdamTadeusz AdamTadeusz marked this pull request as ready for review May 30, 2025 16:07
@AdamTadeusz
Copy link
Contributor Author

figured out why the frame close button wasn't working, now the player can be once again closed with the default close button

Rainyan

This comment was marked as resolved.

Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rainyan Rainyan requested review from a team and brysondev and removed request for brysondev June 27, 2025 13:24
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bugs me that the music button isn't perfectly in the corner but other than that cool

@AdamTadeusz
Copy link
Contributor Author

It bugs me that the music button isn't perfectly in the corner but other than that cool

with the main menu being offset I though it looked weird when the mp3 button was exactly in the corner. I don't expect it to continue looking like this, ideally I wanted something that shows whats being played and the ability to pause while its still mostly hidden, something to think about when replacing this menu with something more consistent with mzync's ui

@AdamTadeusz AdamTadeusz merged commit 4e7fe48 into NeotokyoRebuild:master Jul 3, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 160_b_AddMP3Player branch July 3, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If sound setup is set to "Headphones" then the main music will not play on startup

4 participants