-
Notifications
You must be signed in to change notification settings - Fork 20
MP3 Player #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP3 Player #947
Conversation
…utomatically or otherwise
|
when the keybind cache gets reset both keys should be reset, so probably only need to check the value of one of them and then update all the cached bindings if the first one isn't cached in retrospect |
brysondev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that one nit. Also might wanna enable console by default as well while we're at it.
|
Oh also as a question/general feedback: is there any way to double click a song to have it play instead of spamming "next" or "previous" to get the sound you want? |
…revious playlist around
…g name element so close button works
|
figured out why the frame close button wasn't working, now the player can be once again closed with the default close button |
Rainyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
DESTROYGIRL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It bugs me that the music button isn't perfectly in the corner but other than that cool
with the main menu being offset I though it looked weird when the mp3 button was exactly in the corner. I don't expect it to continue looking like this, ideally I wanted something that shows whats being played and the ability to pause while its still mostly hidden, something to think about when replacing this menu with something more consistent with mzync's ui |
Description
Adds an MP3 player, with the music files in the soundtrack folder of the original being available by default.
-fixes #987