Use EF_NOSHADOW to control weapon shadow state #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rainyan
previously approved these changes
Dec 15, 2024
Rainyan
previously approved these changes
Dec 15, 2024
brysondev
reviewed
Dec 15, 2024
brysondev
reviewed
Dec 15, 2024
brysondev
previously approved these changes
Dec 15, 2024
Contributor
brysondev
left a comment
brysondev
left a comment
There was a problem hiding this comment.
lgtm, just wondering why the method is public
Contributor
Author
I was going to initially use it in neo_gamerules but it turns out that's not necessary, ill fix that |
brysondev
approved these changes
Dec 16, 2024
Rainyan
approved these changes
Dec 16, 2024
AdamTadeusz
deleted the
116_removeShadowsFromNonActiveWeaponsWhenCloaked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Weapons that weren't active weren't getting data updates and so ShadowCastType() wasn't being run for them. This pr switches how we control whether shadows are drawn for weapons specifically to instead use the effect EF_NOSHADOW. I've tested bots toggling cloak on and off manually, bots running out of cloak, bots dropping weapons while cloaked, bots dying while cloaked and the shadow behavior for all of these seems correct.
One situation I can think of that I haven't tested where this might break would be a cloaked player who enabled cloak while not in pvs running into view of the player.
Toolchain
Linked Issues