Third person to first person view model problem fixes #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to it and broken animations all when returning from thirdperson view
brysondev
reviewed
Dec 22, 2024
Contributor
brysondev
left a comment
brysondev
left a comment
There was a problem hiding this comment.
LGTM, gonna try your test cases before giving full approval.
brysondev
previously approved these changes
Dec 22, 2024
Contributor
brysondev
left a comment
brysondev
left a comment
There was a problem hiding this comment.
LGTM
20241222_0939_H.264.mp4
….com/AdamTadeusz/neo into 114_thirdToFirstPersonViewModelFixes
brysondev
approved these changes
Feb 24, 2025
Agiel
approved these changes
Feb 25, 2025
nullsystem
pushed a commit
that referenced
this pull request
Feb 25, 2025
…g to it and broken animations all when returning from thirdperson view (#830) Co-authored-by: brysondev <bryson@brysondev.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some issues with the viewmodel when switching to thirdperson and then back to first person.
Toolchain
Linked Issues
Issue 1: when switching to third person and back to first person, the third person muzzle flash for the gun that was active when in first person will be visible in first person until weapons are switched
Issue 2: when switching between weapons after coming back to first person, the weapon view model flashes briefly in the idle position before disappearing after which ACT_VM_DRAW correctly brings it up from below/side of the screen.
Issue 3: The primary attack animation breaks with continuous use.
Third person isn't a parity feature so I didn't bother to open issues for these, except for the third issue which this PR addresses but its more of a workaround I think.