Skip to content

Visual Studio 2022 support + drop Visual Studio 2013 support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdamTadeusz merged 7 commits into from
May 15, 2024
Merged

Visual Studio 2022 support + drop Visual Studio 2013 support #2

AdamTadeusz merged 7 commits into from
May 15, 2024

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented May 14, 2024 •
edited
Loading

ORIGINAL PR: NeotokyoRevamp/neo#74

  • Check Linux works fine
  • Redo the commits a bit so CE's works are credited properly
  • Update README/docs
  • Can now compile, link, and run using VS2022
  • VS2013 no longer needs to be installed + removed support
    • Removed support for Windows XP SP1???
  • From SDK2013-CE/VS2022 works:
  • Fixed compile errors, suppressed warnings related to upgrading from VS2013 to VS2022
  • Edited the strings on vpc.exe to say Visual Studio 2022 instead of 2013
  • Basically the first part of integrating source-sdk-2013-ce changes into neo, more can start refitting neo + ce changes after this one
  • Extra .gitignores to prevent committing in bsp, pdb
  • Most of the line changed are on memoverride.cpp which is just copied over from SDK2013-CE, most of it is really just around 80~ added/deleted lines
  • Bump minimum instruction set from SSE to SSE2

nullsystem and others added 7 commits April 28, 2024 20:21
@nullsystem
General works to get it working with VS2022
8d30376 
* initializer_list now have to be included on Windows, removed Linux
  only ifdefs also
* include typeinfo.h -> typeinfo
* int:1 -> unsigned int:1 (int:1 goes from -1 to 0)
* virtual deconstructor needed for some classes
* public added to virtual inheritence of IForceVirtualInheritancePanel
* vpc: Removed pointeroverride.asm, only used for WinXP-SP1 support
* vpc: Removed support for compiler toolset lower than v143
* vpc: Supress warnings from C4456;4459;4457;4838;26945;4458;4559;4565
    * Most of them are basically names kind of warnings, not too
      important to deal with. If wanted to, it can be done at a later
      time.
* Take particles.lib from Source-PlusPlus VS2015 fixes by Joshua Ashton
    * b44ac3d0b3333ad2d2af85fa5422fca52ef18b10
@nullsystem
Modified vpc.exe to remove reg key requirement
8635193 
Actually resolves issue (source-sdk-2013-ce:41)
@nullsystem
Take source-sdk-2013-ce's memoverride.cpp into neo
7841e43 
* Commits from source-sdk-2013-ce
    * d03caa912acb907f8605220bb8e5f7ec4a782b58
    * 546d72e09af890727844e117eb667b56c125d0cc
    * f31ba26af3f7cd98e30d29f2611effd9236aa968
    * d3e08b1a1da444883502b89d5c4a4cc1f7bef249
    * 880ebcfab4da0a430fc1c4d737820d11b0c534ec
    * 9908138c0672006c387d164dca2f5fd418a8f2b4
    * 7913e603b6103bece1e62c7e1ddffbc5a91bbf00
* Credits from source-sdk-2013-ce:
    * Nbc66, AnthonyPython, DotWith
@nullsystem
update the markdowns to mention VS2022/de-mention VS2013/v120
caec0da
@nullsystem
Edit text in vpc.exe 2013 -> 2022
a7717b5 
* It's iffy to be doing this, but at least we're stating this is for
  VS2022 now
@nullsystem
Omit pdb from commiting into mp/src/lib/public/
40881aa
@nullsystem
Bump minimum enhanced instruction set from SSE to SSE2
be74326 
Generally all amd64/x86-64 machines have SSE2
@nullsystem nullsystem added the Tooling Tooling related works (EX: OS fixes, libraries) label May 14, 2024
@nullsystem nullsystem requested a review from a team May 14, 2024 19:48
@AdamTadeusz AdamTadeusz merged commit e2f783f into NeotokyoRebuild:master May 15, 2024
Rainyan pushed a commit that referenced this pull request Jul 1, 2024
@AdamTadeusz
Merge pull request #2 from nullsystem/003_VS2022CE
b8cc52b 
Visual Studio 2022 support + drop Visual Studio 2013 support
AdamTadeusz referenced this pull request in AdamTadeusz/neo Nov 10, 2024
@brysondev
Merge pull request #2 from AdamTadeusz/104_sourceBotsVisionAimFixes
6aa658b 
Fixes to aim and view
sunzenshen referenced this pull request in sunzenshen/neo Jul 15, 2025
@AdamTadeusz
Merge pull request #2 from AdamTadeusz/revert-1-bug/sign-extension
e1aa551 
Revert "Fix int to ptr conversion for x64"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VantoNortim VantoNortim VantoNortim approved these changes

Assignees

No one assigned

Labels

Tooling Tooling related works (EX: OS fixes, libraries)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nullsystem @VantoNortim @AdamTadeusz