Disable xray in maps with friendly markers disabled

[DESTROYGIRL]

Description

Title

Toolchain

• Windows MSVC VS2022

Linked Issues

• fixes Xray is enabled in maps where IFF hud elements are disabled #1565

[sunzenshen]

For what it's worth, after cherry picking #1553 into this branch (to fix bots crashing DM mode), I tried setting sv_neo_gamemode_enforcement 1; to force DM mode, and this branch didn't seem to make a difference, as I still see x-rays for enemies on my same team, and no x-rays for enemies on the other team.

Not sure if this fix requires that the map natively supports DM, or if DM mode should be enabled in a different way.

I also tried neo_vote_game_mode 3; mp_restartgame 1; and this didn't work either for disabling the friendly marker in DM mode.

bot-dm-xray-highlight-bug.mp4

(Notice how I am on team NSF and the Jinrai players are not highlighted. In spectate mode they are all highlighted.)

[sunzenshen]

Also I'm not sure if we're keeping the PR changes small in scope, but CNEO_Player::GetFogObscuredRatio probably needs to be updated with a IsTeamplay() check such that enemies from the same team are not fully visible to each other:

float CNEO_Player::GetFogObscuredRatio(CBaseEntity* target) const
{
	/*---[snip]---*/

	if (GetTeamNumber() == targetPlayer->GetTeamNumber())
	{
		// Teammates are always labeled with IFF markers
		return 0.0f;
	}

(CNEOBotVision::IsAbleToSee seems fine already in this context but we might need to sanity check later that we don't forget to keep teammates not omniscient of each other.)

[AdamTadeusz]

master...AdamTadeusz:neo:306_dontGlowDMPlayers heres how you would solve this issue. I was gonna wait until the dm fix was in so it could be tested with bots.

[DESTROYGIRL]

master...AdamTadeusz:neo:306_dontGlowDMPlayers heres how you would solve this issue. I was gonna wait until the dm fix was in so it could be tested with bots.

Would you prefer if I remove that half from this PR and you can submit that seperately

[DESTROYGIRL]

Not handling dm here