Skip to content

Fix alive player counts being incorrect with cl_neo_hud_team_swap_sides #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DESTROYGIRL merged 2 commits into from
Dec 11, 2025
Merged

Fix alive player counts being incorrect with cl_neo_hud_team_swap_sides #1537

DESTROYGIRL merged 2 commits into from
Dec 11, 2025

Conversation

@DESTROYGIRL
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL commented Dec 9, 2025 •
edited by sunzenshen
Loading

Description

If cl_neo_hud_team_swap_sides 0 alive player counts (x vs x) were not updated accordingly
This should not create any issues with #1502

Toolchain

  • Windows MSVC VS2022

@DESTROYGIRL DESTROYGIRL added this to the Bug Cleanup milestone Dec 9, 2025
@DESTROYGIRL DESTROYGIRL requested a review from a team December 9, 2025 15:25
@DESTROYGIRL DESTROYGIRL added the UI/HUD Relates to the HUD, NeoUI, menus, etc label Dec 9, 2025
sunzenshen
sunzenshen previously approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@sunzenshen sunzenshen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A/B Test:

cl_neo_hud_team_swap_sides 0

  • Before or after make the teams uneven
  • Join NSF Team
  • Look at the scoreboard

Before this PR: (Notice 4v3 is incorrect)

Image

After this PR:

Image

@sunzenshen sunzenshen requested a review from a team December 10, 2025 04:18
@DESTROYGIRL
Copy link
Contributor Author

DESTROYGIRL commented Dec 10, 2025

There were conflicts

@DESTROYGIRL DESTROYGIRL merged commit 3339b63 into NeotokyoRebuild:master Dec 11, 2025
7 checks passed
@DESTROYGIRL DESTROYGIRL deleted the 13_fix_hudswapsides_alive branch December 11, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzenshen sunzenshen sunzenshen approved these changes

@AdamTadeusz AdamTadeusz AdamTadeusz approved these changes

Assignees

No one assigned

Labels

UI/HUD Relates to the HUD, NeoUI, menus, etc

Projects

None yet

Milestone

Bug Cleanup

Development

Successfully merging this pull request may close these issues.

3 participants

@DESTROYGIRL @sunzenshen @AdamTadeusz