Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

Description

There is a rare issue that's come up a few times where the ghost marker gets placed on objects which are not the ghost. This PR aims to hopefully solve this issue by creating a networked chandle for the ghost object, and using that instead client side to get the ghost position. This PR also makes the position of the ghost marker when carried by players behave more like in the original

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

  • fixes #

@AdamTadeusz AdamTadeusz marked this pull request as draft November 24, 2025 19:03
Rainyan
Rainyan previously approved these changes Nov 24, 2025
@Rainyan Rainyan requested review from a team and removed request for a team November 24, 2025 19:56
@AdamTadeusz
Copy link
Contributor Author

I didn't know if we should keep m_vecGhostMarkerPos, decided to keep it as a fallback instead of returning vec3_origin.

@DESTROYGIRL
Copy link
Contributor

Could this change also be applied to the juggernaut, as the HUD logic was copied from the ghost?
You should only need to make a handle for the juggernaut item as thats the only thing the marker appears on. But the marker position vector might need to stay as thats used between the juggernaut item and juggernaut player for the compass arrow

@AdamTadeusz
Copy link
Contributor Author

I wanted to but I didn't feel confident doing it since it was behaving a little differently that the ghost so I undid those changes

@AdamTadeusz AdamTadeusz marked this pull request as ready for review November 25, 2025 17:00
@AdamTadeusz AdamTadeusz requested a review from Rainyan November 25, 2025 17:00
@Rainyan Rainyan requested a review from a team November 25, 2025 18:45
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work better now with mp_restartgame 1 (didn't run into the ghost marker following a player bug)

@AdamTadeusz AdamTadeusz merged commit be010d2 into NeotokyoRebuild:master Nov 26, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 298_ghostEHandle branch November 26, 2025 10:06
@Rainyan Rainyan linked an issue Nov 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ghost icon can be attached to a player that didnt pick up the ghost

4 participants