Skip to content

Add function for restricting external cvars/cmds #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rainyan merged 2 commits into from
Nov 21, 2025
Merged

Add function for restricting external cvars/cmds #1489

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff3a2c
Add function for restricting external cvars/cmds
Rainyan Nov 18, 2025
708edaf
add more commands to restrict list
Rainyan Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/game/client/cdll_client_int.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,38 @@ extern IGameSystem *ViewportClientSystem();
//-----------------------------------------------------------------------------
ISourceVirtualReality *g_pSourceVR = NULL;

#ifdef NEO
// Restrict external cheaty ConVars or ConCommands, where we don't have ctor access to set the flags.
static void RestrictNeoClientCheats()
{
if (!g_pCVar)
{
Assert(false);
return;
}

// NEO TODO (Rain): list currently incomplete...
// These cheat names can be either ConVars or ConCommands
constexpr const char* cheats[]{
"building_cubemaps",
"cl_showerror",
"net_showmsg",
};

constexpr auto flags = FCVAR_CHEAT;
for (int i = 0; i < ARRAYSIZE(cheats); ++i)
{
const char* cheatName = cheats[i];
if (auto* var = g_pCVar->FindVar(cheatName))
var->AddFlags(flags);
else if (auto* cmd = g_pCVar->FindCommand(cheatName))
cmd->AddFlags(flags);
else
AssertMsg(false, "convar or concmd named \"%s\" was not found\n", cheatName);
}
}
#endif

// Purpose: Called when the DLL is first loaded.
// Input : engineFactory -
// Output : int
Expand Down Expand Up @@ -1342,6 +1374,7 @@ void CHLClient::PostInit()
g_pCVar->FindVar("neo_clantag")->InstallChangeCallback(NeoConVarStrLimitChangeCallback<NEO_MAX_CLANTAG_LENGTH>);
g_pCVar->FindVar("cl_neo_crosshair")->InstallChangeCallback(NeoConVarStrLimitChangeCallback<NEO_XHAIR_SEQMAX>);
g_pCVar->FindVar("sv_use_steam_networking")->SetValue(false);
RestrictNeoClientCheats();
}
else
{
Expand Down