Skip to content

Conversation

@nullsystem
Copy link
Collaborator

Description

  • Add color customization for crosshair's dot, outline, and dot's outline. Dot's separated color toggle also provided.
  • Updated crosshair serialzation to v4, fixup serialization string size checking.

Toolchain

  • Linux GCC Distro Native Arch/GCC 15

Linked Issues

@nullsystem nullsystem requested a review from a team November 17, 2025 20:31
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this is just me, but exporting and then immediately importing the crosshair isn't working for me when I looked at whether import/export still works:

Image

That said, customization seems to work:

Image

@sunzenshen sunzenshen requested a review from a team November 18, 2025 06:29
@nullsystem
Copy link
Collaborator Author

@sunzenshen Seems to export+import fine on Linux, so possibly Windows-only clipboard issue

sunzenshen
sunzenshen previously approved these changes Nov 19, 2025
@nullsystem nullsystem marked this pull request as draft November 19, 2025 18:22
* Add color customization for crosshair's dot, outline, and dot's
  outline. Dot's separated color toggle also provided.
* Updated crosshair serialzation to v4, fixup serialization string size
  checking.
* fixes NeotokyoRebuild#1483
@nullsystem nullsystem force-pushed the GH-1483_CrosshairExtraColorsCustom branch from 0f88291 to 9e3c608 Compare November 23, 2025 16:43
@nullsystem nullsystem marked this pull request as ready for review November 23, 2025 16:43
Size is in bytes of the destination array, not size in characters
@nullsystem nullsystem force-pushed the GH-1483_CrosshairExtraColorsCustom branch from 9e3c608 to 2532222 Compare November 23, 2025 16:59
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows export/import works for me and also checked that I could save to a notepad and interchange between previous settings:

Screenshot 2025-11-23 211019 image

@sunzenshen sunzenshen requested a review from a team November 24, 2025 04:13
@AdamTadeusz
Copy link
Contributor

Style nit but I think this area would benefit from some headings. Also should draw top line be higher up with the rest of the options that configure the central crosshair?
image

@nullsystem nullsystem merged commit 562a675 into NeotokyoRebuild:master Nov 24, 2025
7 checks passed
@nullsystem
Copy link
Collaborator Author

@AdamTadeusz The UI can be sorted out later when some color widgets gets put in

@DESTROYGIRL DESTROYGIRL added the UI/HUD Relates to the HUD, NeoUI, menus, etc label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/HUD Relates to the HUD, NeoUI, menus, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Extra crosshair color configurations

4 participants