Fix m_rfAttackers... off by 1 #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The array is used as 1-indexed and so `MAX_PLAYER` numbered index could be used. So instead increase the array size by 1 so it can handle that. * 0 index never used, but better that than converting to 0-index when using the array everytime * fixes NeotokyoRebuild#1479
Masterkatze
previously approved these changes
Nov 16, 2025
Rainyan
previously approved these changes
Nov 16, 2025
Rainyan
approved these changes
Nov 16, 2025
Masterkatze
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MAX_PLAYERnumbered index could be used. So instead increase the array size by 1 so it can handle that.Toolchain
Linked Issues
m_rfAttackers...off by 1 #1479