Skip to content

Fix for "Unable to remove user_custom files" #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Masterkatze merged 1 commit into from
Nov 13, 2025
Merged

Fix for "Unable to remove user_custom files" #1471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/game/client/cdll_client_int.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,6 +1249,10 @@ static void NeoDeleteDownloadedSprays()
char szSLSearch[MAX_PATH];
V_sprintf_safe(szSLSearch, "%s/*.dat", szSLRelPath);

// Copy the string before calling FindFirst
char szFNameFLDir[MAX_PATH];
V_strcpy_safe(szFNameFLDir, pszFNameFLDir);

FileFindHandle_t findHdlSL;
for (const char *pszFNameSLDat = filesystem->FindFirst(szSLSearch, &findHdlSL);
pszFNameSLDat && findHdlSL != FILESYSTEM_INVALID_FIND_HANDLE;
Expand All @@ -1275,7 +1279,7 @@ static void NeoDeleteDownloadedSprays()
}

char szFullFPathSLDat[MAX_PATH];
V_sprintf_safe(szFullFPathSLDat, SZ_USERCUSTOM_DIR "/%s/%s", pszFNameFLDir, pszFNameSLDat);
V_sprintf_safe(szFullFPathSLDat, SZ_USERCUSTOM_DIR "/%s/%s", szFNameFLDir, pszFNameSLDat);

// NEO JANK (nullsystem): filesystem API seems buggy having earlier file(s) in alphanum order
// unable to recognize those files and remove them. When RemoveFile was called wasn't the issue
Expand Down