NeoUI - Refactor root NeoUI usages, sound within NeoUI #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullsystem
added
UI/HUD
nullsystem
force-pushed
the
GH-1468_NeoUIRootRefactorSoundRollover
branch
from
166ccfc to
d4cd495
Compare
* Refactor neo_root to not loop around buttons, instead just directly place and use the buttons like the rest of the menus * Put sound rollover into within the NeoUI API and remove manual handling within neo_root. Off by default, just add the new flag to per section and can customize to point to different paths from external to the NeoUI API. * fixes NeotokyoRebuild#1468
nullsystem
force-pushed
the
GH-1468_NeoUIRootRefactorSoundRollover
branch
from
d4cd495 to
fa4bf73
Compare
Masterkatze
previously approved these changes
Nov 9, 2025
sunzenshen
reviewed
Nov 10, 2025
sunzenshen
previously approved these changes
Nov 10, 2025
Contributor
sunzenshen
left a comment
sunzenshen
left a comment
There was a problem hiding this comment.
I had one question about the use case of Assert(localizedWszStr); in neo_root.cpp, but otherwise lgtm.
nullsystem
dismissed stale reviews from sunzenshen and Masterkatze
via
eff5a92
nullsystem
force-pushed
the
GH-1468_NeoUIRootRefactorSoundRollover
branch
from
eff5a92 to
fe06a64
Compare
sunzenshen
approved these changes
Nov 10, 2025
AdamTadeusz
approved these changes
Nov 11, 2025
Masterkatze
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toolchain
Linked Issues