Fix crash when winning by capping the ghost during match point. #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masterkatze
previously approved these changes
Nov 9, 2025
sunzenshen
previously approved these changes
Nov 10, 2025
…ed elsewhere and I can't figure out what purpose this serves.
sunzenshen
approved these changes
Nov 11, 2025
Masterkatze
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send
ghost_captureevent before ending the match and clearingm_iGhosterPlayer.I'm very unsure about calling
StartNextRoundthere because I don't understand the purpose of that if-statement, but if we set the match to Live after callingResetMapSessionCommoninSetWinningTeamwe end up in a weird limbo state. I'd much prefer not callingResetMapSessionCommon, like in #1443, which does fix this crash on it's own, but, as mentioned there, causes a bot crash instead for whatever reason.Toolchain
Linked Issues