Clean up ready players center text. Print number in chat when players ready up. #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masterkatze
previously approved these changes
Oct 25, 2025
Contributor
Masterkatze
left a comment
Masterkatze
left a comment
There was a problem hiding this comment.
IMO we can lower the size of szReadyText and szPrint arrays here, but LGTM overall
Contributor
Author
|
You're right. I'm too lazy to count exactly but it should be better now. |
Masterkatze
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can't make the center text stay longer, so instead clean it up to be more readable. Also print the actual number of ready players in chat each time a players readies or unreadies.
Toolchain
Linked Issues