Skip to content

Conversation

@sunzenshen
Copy link
Contributor

Description

Walking is automatically toggled off when the player starts sprinting.
This means that when sprinting is cancelled the player should return to a state where the movement speed is at a standard pace (neither walking nor sprinting).

Toolchain

  • Windows MSVC VS2022

Linked Issues

@sunzenshen sunzenshen requested a review from a team September 30, 2025 03:34
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect of this is that people who use hold walk rather than toggle will have to press the walk key again after leaving sprint to return to walking state.
It's not a huge issue I guess but I think the expected behaviour would be to return to the walking state if its still held down.

@sunzenshen
Copy link
Contributor Author

sunzenshen commented Oct 1, 2025

Side effect of this is that people who use hold walk rather than toggle will have to press the walk key again after leaving sprint to return to walking state. It's not a huge issue I guess but I think the expected behaviour would be to return to the walking state if its still held down.

Who is still holding walk when they start holding sprint? And who holds walk before they let go of sprint?

I tinkered around with the walk states on the side, but I haven't found a solution where the added extra complication was worth the extra code. You'd almost have to keep track of what the previous walk input state was in order to reactivate the walk again.

@sunzenshen sunzenshen requested a review from a team October 1, 2025 06:08
@Rainyan Rainyan requested review from Rainyan and removed request for a team October 13, 2025 22:14
@sunzenshen sunzenshen merged commit efd63bb into NeotokyoRebuild:master Oct 14, 2025
7 checks passed
@sunzenshen sunzenshen deleted the 1305-sprint-toggle-off-walking branch December 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sprinting should automatically toggle off walking if it was on before

3 participants