Skip to content

JGR Tweaks + squad friendly markers #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DESTROYGIRL merged 12 commits into from
Oct 26, 2025
Merged

JGR Tweaks + squad friendly markers #1398

DESTROYGIRL merged 12 commits into from
Oct 26, 2025

Conversation

@DESTROYGIRL
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL commented Sep 25, 2025 •
edited
Loading

Description

  • Fixes not being able to spawn in JGR
  • Spawns any already dead teammates instantly when the JGR is picked up by a team member
  • Gives the JGR & VIP a unique friendly marker to distinguish them, also gives non-squad members their correct marker back like in OG
  • Always show the JGR position on the compass, regardless of if it's being controlled or not
  • Fix looping boot sound continuing into next round after reset
  • Avoid the first two asserts described in Taking control of Juggernaut should not fail studio assertions #1381 but not all of them

neoAssets >>> NeotokyoRebuild/neoAssets#72

Toolchain

  • Windows MSVC VS2022

Linked Issues

@DESTROYGIRL DESTROYGIRL added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label Sep 25, 2025
@DESTROYGIRL DESTROYGIRL mentioned this pull request Sep 25, 2025
Merged
@DESTROYGIRL DESTROYGIRL requested a review from a team September 25, 2025 11:22
@Rainyan Rainyan self-requested a review October 13, 2025 23:57
@AdamTadeusz AdamTadeusz added the Conflict conflicts with master label Oct 21, 2025
@DESTROYGIRL DESTROYGIRL removed the Conflict conflicts with master label Oct 21, 2025
Rainyan
Rainyan requested changes Oct 25, 2025
View reviewed changes
@Rainyan Rainyan requested a review from a team October 25, 2025 04:48
@DESTROYGIRL DESTROYGIRL requested a review from Rainyan October 25, 2025 17:17
@Rainyan Rainyan requested a review from a team October 26, 2025 18:13
@DESTROYGIRL DESTROYGIRL merged commit a3efb26 into NeotokyoRebuild:master Oct 26, 2025
7 checks passed
@DESTROYGIRL DESTROYGIRL deleted the 0_jgr_postpttweaks branch October 26, 2025 22:10
@DESTROYGIRL DESTROYGIRL added the JGR Related to the Juggernaut gamemode. label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzenshen sunzenshen sunzenshen approved these changes

@Rainyan Rainyan Rainyan approved these changes

Assignees

No one assigned

Labels

Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description JGR Related to the Juggernaut gamemode.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DESTROYGIRL @sunzenshen @Rainyan @AdamTadeusz