Display takeover player name in scoreboard/feed

[sunzenshen]

Description

When a spectator takes over another player, display their name with the format of: "target_name (spectator_name)"
Also rearranges the scoreboard such that it looks like a takeover player is taking the place of the possessed player/bot on the scoreboard.

Toolchain

• Windows MSVC VS2022

Linked Issues

[sunzenshen]

TODO: figure out if going the route of setting the clan name in the scoreboard works better.

[sunzenshen]

(EDIT: Updated screenshots and context after implementing Helper for displaying full takeover context names)

With this iteration that modifies the scoreboard and killfeed, this is what the scoreboard looks like:

These were my settings for setting an excess amount of characters:

Note that with this current iteration of the PR, I am displaying the clan tag in the former-spectator's name, but not in the taken-over bot name. Let me know of your opinions on the formatting.

This is what the killfeed looks like with takeover name:

Note that the clan tag is not displayed. I believe this is similar to the clan tag not being displayed with normal names.

This is what ghost cap looks like:

I made similar refactors for VIP mode, but forgive me for not testing that without the presence of official VIP maps.

As another example, self kill seems to render fine:

Another example is if someone else kills you while you are taking over another player:

[sunzenshen]

Based on feedback from Discord, rearranged the scoreboard such that it looks like you are assuming the identity of the taken over player:

bot_takeover_scoreboard_swap_invisibly.mp4

Under the hood, your scoreboard entry imitates the player you are hijacking, while that hijacked player's entry imitates your stats.

Known name change coverage gaps:

• squad team name list (a.k.a stars)
• spectator focus on a player

The reason I have omitted changing those names is because I think it's debatable whether such replacements are more useful than confusing. The argument for changing the scoreboard and killfeed names is to highlight how scores are transferred from hijacker to hijacked. (To recap earlier discussion, this is a balancing decision to mitigate the scenario of a high skill player using bots to farm experience through multiple lives in the same round, such that they consolidate experience into a single player to purchase high cost loadouts early in a match.)

It may actually be confusing to override the squad team names, because then it adds noise with picking out a teammate's name in the heat of action.
For spectator focus on a player, it's potentially confusing for a competition announcer to parse out the name of a player they are watching and commentating on, especially when the player has a name long enough to hit the max name length edge case.

If there is a desire for name overrides for those cases, I suggest implementing them in a separate PR after discussion.

[DESTROYGIRL]

What does "SAT" mean?
Or rather what does it stand for, if anything

[sunzenshen]

What does "SAT" mean? Or rather what does it stand for, if anything

I meant this to mean SATellite to imply another GITS reference. Other suggestions from Discord include "LNK" for upLiNK, or "RC" for remote control. Maybe we should poll to community and tweak this 3 letter label later?

`

[AdamTadeusz]

I would remove most of the changes in this pr, including the operator thing, the ping changes, move GetPlayerNameWithTakeoverContext to somewhere in c_neo_player, make sure the name returned by it is less than or equal to MAX_PLAYER_NAME_LENGTH and just call it wherever we want to display a player's name with the controller, including in the squad list and in the spectator gui. I wouldn't worry about casters, I don't expect bots to be used in tournaments, and not being consistent by changing how the name is displayed in all these locations is just gonna confuse the player further.

[sunzenshen]

After fixing the merge conflict, performed a quick sanity test that the player UI elements are still working as intended:

^
(break: different round between the two screenshots)
v

That said, I'm not 100% sure if the non-host not having a Steam avatar is a quirk of host vs non-host (or of Steam logins), or if that's some kind of issue with displaying the Steam avatar?

For the record I'm still using the -insecure multiple game client bat script:

hl2_win64.exe -game neo -insecure -allowdebug -sw -dev -multirun +sv_lan 1

[DESTROYGIRL]

Seems to work fine, and is easy to understand for me. I personally would not copy the profile picture over but we are far past the bikesheddery at this point
Also see my comment about m_iClassAtTimeOfDeath naming suggestion