Don't draw crosshair for spectators when hip fire crosshair is enabled #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rainyan
requested changes
Sep 22, 2025
Collaborator
Rainyan
left a comment
Rainyan
left a comment
There was a problem hiding this comment.
Maybe we should move the player ptr dereference stuff to happen after the if ( !pPlayer ) return guard at line 343, to be safe against a crash where the localplayer didn't exist for whatever reason during the Paint call. Not sure how realistic such a case is, but since the safety check exists in the base engine code, it's probably worth following.
Rainyan
approved these changes
Sep 22, 2025
Collaborator
Rainyan
left a comment
Rainyan
left a comment
There was a problem hiding this comment.
LGTM, and thanks for refactoring to just 1 player ptr, much neater now.
sunzenshen
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.