Skip to content

Conversation

@sunzenshen
Copy link
Contributor

Description

When a spectator is focused on a bot that they can take over, display a hint letting them know that they can take over a bot with the use key.

Toolchain

  • Windows MSVC VS2022

Linked Issues

@sunzenshen sunzenshen requested review from a team and nullsystem September 22, 2025 07:41
@sunzenshen
Copy link
Contributor Author

The latter part of this video shows a persistent client-side option to change the length of the hint lifetime, such that the hint could be disabled if a player already understands how the feature works and doesn't want that UI element showing up. (For example, they want to record gameplay without that hint showing up.)

bot_takeover_configurable_hint_timer.mp4

Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also upon starting the game I get hit with assert hud.cpp (444) : Assertion Failed: false

@sunzenshen
Copy link
Contributor Author

If a user has a keybind for +use, this is what it looks like so far:

keybind_display

@sunzenshen sunzenshen requested review from a team and DESTROYGIRL October 4, 2025 20:29
@AdamTadeusz
Copy link
Contributor

wait, why is this using neoui

@sunzenshen
Copy link
Contributor Author

wait, why is this using neoui

Admittedly, in the beginning I wanted to try learning how to use the neoui framework. On the other hand, maybe it would be much easier to override the player name text in the existing spectator hud, to write something underneath?

I'll give a try at the existing refactor suggestions, but if I hit a roadblock, I might consider looking at the spectator hud.

@sunzenshen sunzenshen force-pushed the bot_takeover_ui_hint_how_to_press_use branch from 0644dab to 182a61a Compare October 12, 2025 21:58
@sunzenshen
Copy link
Contributor Author

Pardon the squash, but I realized in the middle of making changes that there was a conflict when rebasing.

There was some discussion on Discord regarding which style of hint should show, so I added a config option to choose either a new minimal style, a refactor of the current central style we have been reviewing, and not showing the hint at all:

Config

(And the other two option settings:)

minimal Never

This is what a "Central" config looks like:

Central hint

And this is what the "Minimal" hint looks like:

Minimal hint

@DESTROYGIRL DESTROYGIRL self-requested a review October 12, 2025 22:37
@sunzenshen sunzenshen requested a review from a team October 13, 2025 02:45
@AdamTadeusz
Copy link
Contributor

Generally I think this PR is more complicated than it needs to be, I would only add the hint element and make it more general to support different hints like press use to pick up weapon or interact with buttons in the future, with a single option to disable hints.

@sunzenshen sunzenshen force-pushed the bot_takeover_ui_hint_how_to_press_use branch from 182a61a to ec97fb9 Compare October 15, 2025 07:19
@sunzenshen
Copy link
Contributor Author

Took a shot at making the hud element a bit more general with the spectator bot takeover as the first use case.

Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feel like it should use the neuropol font but i might extend upon this in the future and we could look at it then

@sunzenshen sunzenshen merged commit f12ea22 into NeotokyoRebuild:master Oct 22, 2025
7 checks passed
@sunzenshen sunzenshen removed the request for review from nullsystem October 22, 2025 01:24
@sunzenshen sunzenshen deleted the bot_takeover_ui_hint_how_to_press_use branch December 6, 2025 00:59
@DESTROYGIRL DESTROYGIRL added the UI/HUD Relates to the HUD, NeoUI, menus, etc label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/HUD Relates to the HUD, NeoUI, menus, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants