Fix grenade ear-ringing carrying over to next round #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Rainyan
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Rainyan
force-pushed
the
bug/event-carryover
branch
from
560cae7 to
3f3f32f
Compare
Collaborator
Author
|
I wasn't able to reproduce the problem, tested with edit: The server-sided ear-ringing SFX clear was not sent as a reliable message, so this might explain why it's so hard to reproduce. More info in the 37c28b1 commit message. |
Rainyan
changed the title
Contributor
|
I'm surprised dsp_off isn't cheat protected |
Rainyan
added a commit
to Rainyan/rebuild
that referenced
this pull request
Oct 7, 2025
Reset the ear-ringing sound effect caused by standing near grenade/det explosions at spawn/respawn at client side. The server already does this by default via `CBasePlayer::Spawn`, but we want to ensure that reset arrives on time (and reliably; the default recipient filter is not marked reliable) for the remote client. This is done to address NeotokyoRebuild#1376 The reason this bug seems difficult to reproduce may be related to the fact the server-sided recipient filter wasn't marked reliable, so you might need a dropped packet for it to occur, but this is just speculation on my part. For alternatives considered, see the orphaned commits from before the rebase, and the dicussion at NeotokyoRebuild#1383: * 0d4ef5f * 3f3f32f * 564a57c
Rainyan
force-pushed
the
bug/event-carryover
branch
from
564a57c to
1bd8a72
Compare
Collaborator
Author
Hmm, it should be. As far as I can tell, it's defined in the engine library, with flags 0x44000 (so Also shows up as cheat-protected for both NT & NT;RE in the client console: 
|
Reset the ear-ringing sound effect caused by standing near grenade/det explosions at spawn/respawn at client side. The server already does this by default via `CBasePlayer::Spawn`, but we want to ensure that reset arrives on time (and reliably; the default recipient filter is not marked reliable) for the remote client. This is done to address NeotokyoRebuild#1376 The reason this bug seems difficult to reproduce may be related to the fact the server-sided recipient filter wasn't marked reliable, so you might need a dropped packet for it to occur, but this is just speculation on my part. For alternatives considered, see the orphaned commits from before the rebase, and the dicussion at NeotokyoRebuild#1383: * 0d4ef5f * 3f3f32f * 564a57c
Rainyan
force-pushed
the
bug/event-carryover
branch
from
1bd8a72 to
37c28b1
Compare
We already reset the ear-ringing explosion SFX for clients locally at spawn in `C_NEO_Player` first spawn tick, but we should also send the server sided message reliably for the benefit of in-eye spectators (since they would not be the local player and hence not receive the client-sided clear).
Collaborator
Author
|
Also snuck in 66caecb for playing the ear-ringing SFX for in-eye observers. |
AdamTadeusz
approved these changes
Oct 12, 2025
sunzenshen
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a case where the ear-ringing effect from a nearby grenade explosion could carry over to the next round with really unfortunate timing, where the nade goes off just as the round is about to end.
Toolchain
Linked Issues