Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

Description

Replaces the ImagePanel Button couples in the class and loadout selection menus with a single neoImageButton object, removes the incorrect border and adds an on hover border like in the original

@AdamTadeusz AdamTadeusz requested a review from a team September 19, 2025 19:55
@sunzenshen sunzenshen requested a review from a team September 20, 2025 05:00
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Loaded up a few clients and verified that the correct models are displayed after selection. (I figure weapons not being selected correctly will be a bit more obvious to detect during playtests.)

model_selection_nsf.mp4
model_selection_jinrai.mp4

@sunzenshen sunzenshen requested a review from a team September 21, 2025 04:12
@AdamTadeusz AdamTadeusz merged commit 04faac4 into NeotokyoRebuild:master Oct 3, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 278_neoImageButton branch October 3, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants