Reduce likelihood that bots fire through friendlies #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunzenshen
force-pushed
the
bot-reduce-friendly-fire
branch
from
b331bc0 to
d82d13f
Compare
sunzenshen
force-pushed
the
bot-reduce-friendly-fire
branch
from
d82d13f to
7151e48
Compare
sunzenshen
commented
Oct 22, 2025
AdamTadeusz
approved these changes
Nov 7, 2025
Contributor
AdamTadeusz
left a comment
AdamTadeusz
left a comment
There was a problem hiding this comment.
if memory serves CTraceFilterChain requires that an entity is hit by both filters that make up the filter chain, so a custom CTraceFilterChain would have to be added where the shouldhit checks whether either of the filters that make it up would hit instead of only if both should hit, so im just gonna approve this for now, maybe add a TODO to simplify this in the future
Masterkatze
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for friendlies between bot and target before opening fire.
Toolchain
Linked Issues