Skip to content

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Aug 29, 2025

Description

  • The bots should now able to fire at breakables and continue on their
    path
  • Hard/Expert bots will also utilize secondary if possible to shoot at
    breakables instead

Toolchain

  • Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

@nullsystem nullsystem force-pushed the GH-1327_BotsShootAtBreakables branch from 15dd788 to d581569 Compare September 6, 2025 12:54
@nullsystem nullsystem changed the title [WIP - Relies on another PR] Bots - Shoot at breakables Bots - Shoot at breakables Sep 6, 2025
@nullsystem nullsystem marked this pull request as ready for review September 6, 2025 12:54
@nullsystem nullsystem requested a review from a team September 6, 2025 13:53
sunzenshen
sunzenshen previously approved these changes Sep 7, 2025
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior LGTM, though there was one time initially where a bot wouldn't break the glass, though I didn't see that behavior again in later attempts:

bot_break_glass_for_objective_fluke_failure_to_compute.mp4

Expert bots use secondary to break glass:

bot_break_glass_for_objective_expert_use_secondary.mp4

Novices did not swap weapon to break glass:

bot_break_glass_for_objective_novice_use_primary.mp4

(Used noclip to grab the ghost and toss it behind breakable glass if random spawn did not put the ghost behind glass.)

@sunzenshen sunzenshen requested a review from a team September 7, 2025 06:40
@AdamTadeusz AdamTadeusz added the Conflict conflicts with master label Sep 11, 2025
@AdamTadeusz
Copy link
Contributor

image

I saw twice an instance where a bot on shrine would stand in this spot and to get to the ghost they would shoot at the fence to the right instead, didn't record it though

@AdamTadeusz
Copy link
Contributor

Also in this spot they often miss the door if a part of the door is broken which means the auto lean makes them lean around the remaining part of the door they are trying to destroy

@AdamTadeusz
Copy link
Contributor

Looking at the code I don't see anywhere where the bot turns specifically to look at the breakable when they open fire, would it make sense to turn the bot towards the breakable entity?

@AdamTadeusz
Copy link
Contributor

Also surely hard/expert bots should use their knife if they have one

@Rainyan Rainyan requested review from Rainyan and removed request for a team November 4, 2025 14:12
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nullsystem Could you please rebase this on top of current master to resolve the conflict (I was running into a crash that I can't repro on master, so maybe it's already resolved in some change)?

@sunzenshen sunzenshen added the Bots Related to bot players label Dec 10, 2025
* The bots should now able to fire at breakables and continue on their
  path
* Hard/Expert bots will also utilize secondary if possible to shoot at
  breakables instead
* fixes NeotokyoRebuild#1327
@nullsystem nullsystem force-pushed the GH-1327_BotsShootAtBreakables branch from d581569 to 33a9f4b Compare December 10, 2025 18:50
@sunzenshen sunzenshen removed the Conflict conflicts with master label Dec 11, 2025
@sunzenshen sunzenshen requested a review from Rainyan December 11, 2025 01:34
@nullsystem nullsystem merged commit b33acdb into NeotokyoRebuild:master Dec 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bots Related to bot players

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bots - Bots unable to shoot at breakables

4 participants