Use class name for killer info, unify name for all neo_npc_targetsystem #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunzenshen
approved these changes
Sep 3, 2025
Contributor
sunzenshen
left a comment
sunzenshen
left a comment
There was a problem hiding this comment.
Not sure which map has a generic turret, but the new name for the tank looks good to me:
Deaths by players still looks okay too.
Contributor
|
Would it make more sense to change the targetname of the neo_npc_targetsystem on rogue to "184-J IFV" and just display the targetname? |
Contributor
Author
No if we wanted to go down that route it'd be better to have a seperate keyvalue in the entity for the display name, but at that point we may as well put it on every single entity that can hurt the player |
AdamTadeusz
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetClassnameinstead ofGetDebugNameas mappers can set the targetname to pretty much anythingToolchain