Skip to content

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Aug 26, 2025

Description

  • Fix scores not being cleared properly between rounds
  • Readjust widths when there's long names
  • Fix suicide kills not being recognized, and further different infos given for suicide kills
  • Recognize environmental and kill command suicide kills
  • Do not display the HUD if there's nothing to display at all
  • Hidden convar: cl_neo_kdinfo_debug_show_local which can be useful to test name lengths
  • More sanity checking

Toolchain

  • Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

* Fix scores not being cleared properly between rounds
* Readjust widths when there's long names
* Fix suicide kills not being recognized, and further different infos
  given for suicide kills
* Do not display the HUD if there's nothing to display at all
* More sanity checking
* fixes NeotokyoRebuild#1301
@nullsystem nullsystem requested a review from a team August 26, 2025 19:10
@nullsystem nullsystem requested a review from AdamTadeusz August 27, 2025 19:44
Copy link
Contributor

@AdamTadeusz AdamTadeusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about putting "YOU KILLED YOURSELF" right above "Killed by Jeff" but it does get the point that you died to the map as opposed to a player called Jeff so ehh

@nullsystem nullsystem requested a review from a team August 27, 2025 22:29
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked self kill related message
image
  • Checked message for drowning
image
  • Checked death by tank
image
  • Scores between rounds or between TDM deaths seem fine? One time TDM showed a stale damage dealt message fresh a self kill on spawn, but I couldn't get it to replicate after I saw it.

  • To be honest, could not check without adjusted widths when there's long names by myself.

  • Checked that summary doesn't show up on successful found round survival

@nullsystem nullsystem merged commit 9cb1e89 into NeotokyoRebuild:master Aug 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Damage dealt not cleared between rounds

3 participants