Fix dropped weapons sometimes appearing pitch black #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DESTROYGIRL
approved these changes
Aug 23, 2025
sunzenshen
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that when drawing entities, their origin is used as the lighting origin. Since the origins of weapons are often placed at the handle, or in the case of grenades outside the weapons model completely, some weapons can appear very dark when dropped as their origin falls through the floor. This PR sets the lighting origin of weapons to their world space center instead. While not ideal, with some really small weapons like the grenades still appearing a bit dark sometimes, it either improves or solves the issue in all cases from what I've tested.
Before:
After:
Toolchain