-
Notifications
You must be signed in to change notification settings - Fork 20
NeoUI - Add and remove server favorites #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeoUI - Add and remove server favorites #1297
Conversation
|
I did notice on the blacklist one there was no add to favorites option |
4fe0bc1 to
0f7f3b1
Compare
0f7f3b1 to
54c26bc
Compare
* Just in the details section can toggle * Right-click add/remove server favorite * fixes NeotokyoRebuild#1267
54c26bc to
9fa1eb5
Compare
|
Since its still possible to add to blacklist in the details tab I wonder if it should be possible to add to favourites in the details tab, also would be nice to have a "favourited" column in the internet and lan tabs |
|
@AdamTadeusz I don't get it, this PR already have the ability to add/remove favorites in details tab? |
|
Indeed it does nvm |
DESTROYGIRL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that if you have a server favourited before ever touching it using the in game UI, it will give you the option to favourite the server despite already having it favourited.
Adding it to favourites from the UI is fine in that scenario and fixes the issue, even if after you make changes externally. So I don't imagine this will ever be a problem for future players
|
@DESTROYGIRL I'm also not too sure how the fav/unfav will workout unless it's properly done within a Steam installed NT;RE, but guess just wait for the playtest to properly find out. |
|
I was testing it on the steam version because there aren't any SDK 2013 run NTRE servers anymore. It works fine as I described |
Description
Toolchain
Linked Issues