Skip to content

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Aug 22, 2025

Description

  • In the details section can toggle
  • Right-click add/remove server favorite

Toolchain

  • Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

@AdamTadeusz
Copy link
Contributor

I did notice on the blacklist one there was no add to favorites option

@nullsystem nullsystem changed the title NeoUI - Add and remove server favorites [WIP] NeoUI - Add and remove server favorites Aug 22, 2025
@nullsystem nullsystem force-pushed the GH-1267_AddRemoveServerFavorite branch 4 times, most recently from 4fe0bc1 to 0f7f3b1 Compare September 13, 2025 11:02
@nullsystem nullsystem marked this pull request as ready for review September 13, 2025 11:02
@nullsystem nullsystem marked this pull request as draft September 13, 2025 11:04
@nullsystem nullsystem changed the title [WIP] NeoUI - Add and remove server favorites [REVIEW NEOUI BRANCH FIRST] NeoUI - Add and remove server favorites Sep 13, 2025
@nullsystem nullsystem changed the title [REVIEW NEOUI BRANCH FIRST] NeoUI - Add and remove server favorites [REVIEW #1344 FIRST] NeoUI - Add and remove server favorites Sep 13, 2025
@nullsystem nullsystem force-pushed the GH-1267_AddRemoveServerFavorite branch from 0f7f3b1 to 54c26bc Compare September 21, 2025 11:14
@nullsystem nullsystem changed the title [REVIEW #1344 FIRST] NeoUI - Add and remove server favorites NeoUI - Add and remove server favorites Sep 21, 2025
@nullsystem nullsystem marked this pull request as ready for review September 21, 2025 11:14
* Just in the details section can toggle
* Right-click add/remove server favorite
* fixes NeotokyoRebuild#1267
@nullsystem nullsystem force-pushed the GH-1267_AddRemoveServerFavorite branch from 54c26bc to 9fa1eb5 Compare September 21, 2025 11:15
@nullsystem nullsystem requested a review from a team September 21, 2025 11:16
@AdamTadeusz
Copy link
Contributor

Since its still possible to add to blacklist in the details tab I wonder if it should be possible to add to favourites in the details tab, also would be nice to have a "favourited" column in the internet and lan tabs

@AdamTadeusz AdamTadeusz requested a review from a team September 21, 2025 12:27
@nullsystem
Copy link
Collaborator Author

@AdamTadeusz I don't get it, this PR already have the ability to add/remove favorites in details tab?

@AdamTadeusz
Copy link
Contributor

Indeed it does nvm

Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that if you have a server favourited before ever touching it using the in game UI, it will give you the option to favourite the server despite already having it favourited.
Adding it to favourites from the UI is fine in that scenario and fixes the issue, even if after you make changes externally. So I don't imagine this will ever be a problem for future players

@nullsystem nullsystem merged commit ed5a266 into NeotokyoRebuild:master Sep 21, 2025
7 checks passed
@nullsystem
Copy link
Collaborator Author

@DESTROYGIRL I'm also not too sure how the fav/unfav will workout unless it's properly done within a Steam installed NT;RE, but guess just wait for the playtest to properly find out.

@DESTROYGIRL
Copy link
Contributor

I was testing it on the steam version because there aren't any SDK 2013 run NTRE servers anymore. It works fine as I described

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NeoUI serverlist - Add/remove server favorite

3 participants