Weapons drop refactor #1296
Merged
Weapons drop refactor #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunzenshen
reviewed
Aug 24, 2025
DESTROYGIRL
reviewed
Aug 24, 2025
Contributor
Author
|
good spot, also I just realised invmass stands for inverted mass, should make more sense now |
DESTROYGIRL
approved these changes
Aug 24, 2025
nullsystem
approved these changes
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hopefully fixes the problem with spectators having guns. Copies CBaseCombatCharacter::Weapon_DropAll 's mechanic of dropping the active weapon last, also removes any weapons that cannot be dropped (currently only the knife, actually can be dropped in the original, perhaps should revert this change?)
Toolchain