Refactor loadout source code and header usages #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullsystem
force-pushed
the
GH-1287_RefactorLoadoutCodeAndHeaders
branch
6 times, most recently
from
728a25f to
897ca46
Compare
sunzenshen
reviewed
Aug 20, 2025
sunzenshen
reviewed
Aug 20, 2025
* New headers and re-arranged around for less of a chance of annoying compiler+linker errors when trying to work on adding new source codes * Loadout completely refactored to reduce repetative defined weapons and simplified to just using two arrays * Fixed some PBK related codes although viewmodel still missing * fixes NeotokyoRebuild#1287
nullsystem
force-pushed
the
GH-1287_RefactorLoadoutCodeAndHeaders
branch
from
897ca46 to
593216d
Compare
Collaborator
Author
|
@sunzenshen I've did some further refactoring, removing the need for total per class loadouts and loadout menu to use a single loop going through the loadout. I've also fixed some PBK56S related stuff, only the viewmodel + loadout image broken but the asserts fixed for PBK. |
sunzenshen
approved these changes
Aug 21, 2025
Rainyan
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
m_szAmmoTypeas that's never usedToolchain
Linked Issues