Don't draw smoke fog overlay when xraying #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunzenshen
reviewed
Aug 19, 2025
DESTROYGIRL
approved these changes
Aug 19, 2025
sunzenshen
approved these changes
Aug 20, 2025
Contributor
sunzenshen
left a comment
sunzenshen
left a comment
There was a problem hiding this comment.
To test this start a match with bots, spawn as a support, throw a smoke, kill yourself, go into free roam spectate mode and fly into the smoke, enable xray, and look towards the bots.
Tried this out and works as expected.
AdamTadeusz
deleted the
265_lowerSmokeFogOverlayAlphaWhenXrayingSoCanXrayThroughSmokes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The value of g_SmokeFogOverlayAlpha is calculated somewhere in the engine and prevents the xray overlay from working, g_SmokeFogOverlayThermalOverride isn't enough to fix it since we don't have access to that code so have to set the value of g_SmokeFogOverlayAlpha to 0 to get it working again.
To test this start a match with bots, spawn as a support, throw a smoke, kill yourself, go into free roam spectate mode and fly into the smoke, enable xray, and look towards the bots.
Will still draw the smoke fog overlay in the case where we are on a team and mp_forcecamera is set to anything other than OBS_ALLOW_ALL