Skip to content

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Aug 13, 2025

Description

  • Uses our own blacklist: ntre_server_blacklist.txt
  • Format is similar to SDK's blacklist, except it can deal with by "name contains" blacklisting and uses uint64 serialization for time instead
  • New blacklist tab which have its own dedicated list
  • Import which can also work with SDK's blacklist, but export is strictly NT;RE blacklist only
  • Usual actions like SDK's: Add server to blacklist, add custom hostname/IP to blacklist
  • Windows: Add Ws2_32.lib to link to tier1

Toolchain

  • Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

@nullsystem nullsystem marked this pull request as draft August 13, 2025 22:04
@nullsystem nullsystem marked this pull request as ready for review August 13, 2025 22:13
@nullsystem nullsystem requested a review from a team August 13, 2025 22:51
@sunzenshen sunzenshen requested a review from a team August 15, 2025 06:37
@nullsystem
Copy link
Collaborator Author

I've also changed the selected visuals which is now white background, black text for better contrast. I may also apply this for the rest when applicable but this is enough for the server list for the time being.

@nullsystem nullsystem added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Aug 15, 2025
@nullsystem nullsystem requested a review from sunzenshen August 19, 2025 09:14
sunzenshen
sunzenshen previously approved these changes Aug 20, 2025
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked up the single server that is up:
image

Then added that same IP to the blocklist in game:
image

Which then removed the server from the active servers list.

Then removed the IP from the blacklist and then saw the server appear again.

@nullsystem nullsystem requested a review from a team August 21, 2025 09:49
@AdamTadeusz
Copy link
Contributor

I notice that adding a server to the blacklist from the server browser works fine, but when adding an item to the blacklist either via hostname/ip or containing string that the game freezes for a solid second, most noticeable if the menu background music is playing in the background. This is regardless of the pause music on window unfocus so the game going out of focus is probably not the problem

@AdamTadeusz

This comment was marked as resolved.

@nullsystem
Copy link
Collaborator Author

@AdamTadeusz I intend to get rid of the legacy button once all its features fully implement in NeoUI (just tags and auto retry I think).

@nullsystem
Copy link
Collaborator Author

I notice that adding a server to the blacklist from the server browser works fine, but when adding an item to the blacklist either via hostname/ip or containing string that the game freezes for a solid second, most noticeable if the menu background music is playing in the background. This is regardless of the pause music on window unfocus so the game going out of focus is probably not the problem

@AdamTadeusz I don't really have the issue with freezing for a second, it's instant for me.

@AdamTadeusz
Copy link
Contributor

perhaps its a windows only issue, ill check if I can replicate it again

@AdamTadeusz
Copy link
Contributor

stutterWhenAddingToBlackList.mp4

* Uses are own blacklist: ntre_server_blacklist.txt
* Format is similar to SDK's blacklist, except it can deal with by "name
  contains" blacklisting and uses uint64 serialization for time instead
* New blacklist tab which have its own dedicated list
* Import which can also work with SDK's blacklist, but export is
  strictly NT;RE blacklist only
* fixes NeotokyoRebuild#1268
@nullsystem
Copy link
Collaborator Author

nullsystem commented Sep 10, 2025

@AdamTadeusz I figured it out, there's the ability to check the DNS/server if it's given a hostname and try to resolve it. On Windows it have a second timeout to resolve it, in the case where a valid hostname given (like an "example.com" site), then it doesn't freeze, if it's invalid like "123abc" then it does freeze a bit. The only change I've done is to only do it if hostname/IP filter selected so shouldn't affect string based filtering anymore.

Also by the way, you can see the same behavior exhibited by the legacy blacklist custom hostname/IP add dialog also.

@AdamTadeusz
Copy link
Contributor

just out of curiosity, what do we gain from resolving the hostname? Since we don't display whether the hostname is valid or not anywhere would it make sense to just skip this altogether?

@nullsystem
Copy link
Collaborator Author

just out of curiosity, what do we gain from resolving the hostname? Since we don't display whether the hostname is valid or not anywhere would it make sense to just skip this altogether?

Mostly cause it's stored and compared as IP+port so hostnames have to resolve it to be usable for filtering. I think it's unlikely hostname will be used anyway as it's usually IP+port when people are dealing with servers and kind of on the player to provide a connectable hostname anyway.

@nullsystem nullsystem merged commit 916732f into NeotokyoRebuild:master Sep 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NeoUI serverlist - Server blacklisting

4 participants