Bots - Utilize auto lean #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nullsystem merged 1 commit into NeotokyoRebuild:master from nullsystem:GH-1265_BotsAutoLean

Aug 19, 2025

Collaborator

nullsystem commented Aug 11, 2025 •

edited

Loading

Description

Supports only lean on aim, other leans on walk + aim
NOTICE: Aim-only lean only really see-able when combined with the bots aim branch

Toolchain

Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

fixes Bots - Utilize (auto) lean #1265

nullsystem force-pushed the GH-1265_BotsAutoLean branch from ac779f6 to 2b32289 Compare

August 11, 2025 20:48

nullsystem requested a review from a team

August 11, 2025 20:52

sunzenshen reviewed

View reviewed changes

src/game/server/NextBot/Player/NextBotPlayer.h Outdated Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/server/NextBot/Player/NextBotPlayer.h Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/shared/neo/neo_predicted_viewmodel.cpp Outdated Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/shared/neo/neo_predicted_viewmodel.cpp Outdated Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/shared/neo/neo_predicted_viewmodel.cpp Outdated Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/shared/neo/neo_predicted_viewmodel.cpp Outdated Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/shared/neo/neo_predicted_viewmodel.cpp Outdated Show resolved Hide resolved

sunzenshen reviewed

View reviewed changes

src/game/shared/neo/neo_predicted_viewmodel.cpp Show resolved Hide resolved

sunzenshen requested a review from a team

August 15, 2025 06:36

nullsystem force-pushed the GH-1265_BotsAutoLean branch from 2b32289 to 4d11157 Compare

August 15, 2025 19:21

nullsystem requested a review from sunzenshen

August 15, 2025 19:23

nullsystem added the New Changes for Reviewers label

sunzenshen previously approved these changes

View reviewed changes

Contributor

sunzenshen left a comment

Overall impression from watching bot matches is that while sometimes the auto-lean triggers in some unintuitive directions, it doesn't seem to impact bot survivability negatively, and I think this behavior accidentally helps the situation where bots are in a single file and all want to open fire. At this point waiting for others to take a look at this build and share their feelings on this change.

sunzenshen requested a review from a team

August 16, 2025 21:43

AdamTadeusz previously approved these changes

View reviewed changes


          Bots - Utilize auto lean

78de580

* Supports only lean on aim, other leans on walk + aim
* fixes NeotokyoRebuild#1265

nullsystem dismissed stale reviews from AdamTadeusz and sunzenshen via

78de580

August 18, 2025 12:03

nullsystem force-pushed the GH-1265_BotsAutoLean branch from 4d11157 to 78de580 Compare

August 18, 2025 12:03

nullsystem requested review from AdamTadeusz and sunzenshen

August 18, 2025 12:03

Collaborator Author

nullsystem commented Aug 18, 2025 •

edited

Loading

Branch rebased to fix the conflicts (they're just #endif vs #endif // NEO style differences)

AdamTadeusz approved these changes

View reviewed changes

sunzenshen approved these changes

View reviewed changes

nullsystem merged commit b2a6ca4 into NeotokyoRebuild:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Changes for Reviewers