Skip to content

NeoUI - Clipboard + selection + free-cursor for TextEdit #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nullsystem merged 2 commits into from
Aug 14, 2025
Merged

NeoUI - Clipboard + selection + free-cursor for TextEdit #1256

nullsystem merged 2 commits into from
Aug 14, 2025

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Aug 3, 2025 •
edited
Loading

Description

  • Add right-click menu for NeoUI, only used by TextEdit for clipboard functionality
  • Clipboard actions envoked both by keybind and right-click menu
  • Add selection support for TextEdit
  • Cursor set on any position other than final + paste in-between texts
  • Text selection with shift modifier + HOME/END/LEFT/RIGHT
  • Prev/next word with ctrl modifier + LEFT/RIGHT (vgui ctrl modifier behavior)
  • Password TextEdit toggle now a flag in function rather than context bool variable
  • TODO later?: Multi-lined text editor, read-only mode, slider's text editor. Those can be done later as this PR is already long.
  • Refactored NeoUI mouse handling, added ability to override foreground/text color
  • Mark create server password field as password if streamer mode is on

Toolchain

  • Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

@nullsystem nullsystem force-pushed the GH-1255_NeoUICutCopyPaste branch 4 times, most recently from 8619db1 to eda088c Compare August 7, 2025 00:49
@nullsystem nullsystem changed the title [DO NOT REVIEW, TODO WIP] NeoUI - Cut, Copy, and Paste/Clipboard for TextEdit [DO NOT REVIEW, TODO WIP] NeoUI - Clipboard + selection + free-cursor for TextEdit Aug 7, 2025
@nullsystem nullsystem changed the title [DO NOT REVIEW, TODO WIP] NeoUI - Clipboard + selection + free-cursor for TextEdit [DO NOT REVIEW] NeoUI - Clipboard + selection + free-cursor for TextEdit Aug 7, 2025
@nullsystem nullsystem force-pushed the GH-1255_NeoUICutCopyPaste branch 10 times, most recently from 933a2d6 to bb68695 Compare August 9, 2025 14:59
@nullsystem nullsystem changed the title [DO NOT REVIEW] NeoUI - Clipboard + selection + free-cursor for TextEdit NeoUI - Clipboard + selection + free-cursor for TextEdit Aug 9, 2025
@nullsystem nullsystem requested a review from a team August 9, 2025 15:00
@nullsystem nullsystem marked this pull request as ready for review August 9, 2025 15:00
@Rainyan Rainyan self-requested a review August 9, 2025 17:01
Rainyan

This comment was marked as resolved.

Sign in to view

@nullsystem nullsystem force-pushed the GH-1255_NeoUICutCopyPaste branch 2 times, most recently from 801988f to c4e9b17 Compare August 12, 2025 18:44
@nullsystem nullsystem requested a review from Rainyan August 12, 2025 18:46
@nullsystem nullsystem force-pushed the GH-1255_NeoUICutCopyPaste branch from c4e9b17 to ff55820 Compare August 12, 2025 18:50
@nullsystem
Copy link
Collaborator Author

nullsystem commented Aug 12, 2025

It would also be nice if we could have the main menu "Create Server" submenu's password field be responsive to whether streamer mode is on/off. So that if the user had streamer mode enabled, the create server password would also be hidden with asterisks, to prevent it from leaking to their viewers.

Added it in now

@Masterkatze
Copy link
Contributor

Masterkatze commented Aug 12, 2025

Just tested in on Linux - works without any issues, nice!

Text selection with shift modifier + HOME/END/LEFT/RIGHT

Can you also add Ctrl key modifier (moving without text selection)? That would be great.

@nullsystem nullsystem force-pushed the GH-1255_NeoUICutCopyPaste branch from ff55820 to 2e51c61 Compare August 12, 2025 20:31
@nullsystem
Copy link
Collaborator Author

nullsystem commented Aug 12, 2025

Just tested in on Linux - works without any issues, nice!

Text selection with shift modifier + HOME/END/LEFT/RIGHT

Can you also add Ctrl key modifier (moving without text selection)? That would be great.

@Masterkatze Added it in now, it's like the vgui behavior where it always moves to the first character of word even for ctrl+right and just uses spaces as deliminator, which is different to how EX: a web browser deals with it.

@nullsystem
NeoUI - Cut, Copy, and Paste/Clipboard for TextEdit
7ecb8de 
* Add right-click menu for NeoUI, only used by TextEdit for clipboard
  functionality
* Clipboard actions envoked both by keybind and right-click menu
* Add selection support for TextEdit
* Cursor set on any position other than final
* fixes NeotokyoRebuild#1255
@nullsystem nullsystem force-pushed the GH-1255_NeoUICutCopyPaste branch from 2e51c61 to 7ecb8de Compare August 12, 2025 20:35
@nullsystem nullsystem added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Aug 12, 2025
Rainyan
Rainyan requested changes Aug 12, 2025
View reviewed changes
@nullsystem nullsystem requested a review from Rainyan August 12, 2025 23:36
Rainyan
Rainyan approved these changes Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rainyan Rainyan requested a review from Masterkatze August 14, 2025 16:33
Masterkatze
Masterkatze approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@Masterkatze Masterkatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullsystem nullsystem merged commit 30ef642 into NeotokyoRebuild:master Aug 14, 2025
7 checks passed
@nullsystem nullsystem mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Masterkatze Masterkatze Masterkatze approved these changes

@Rainyan Rainyan Rainyan approved these changes

Assignees

No one assigned

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] NeoUI - Cut, Copy, and Paste TextEdit

3 participants

@nullsystem @Masterkatze @Rainyan