Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

Description

Makes the background map option readable

Nagrywanie.ekranu.2025-08-01.160420.mp4

Toolchain

  • Windows MSVC VS2022

@AdamTadeusz AdamTadeusz requested review from a team and nullsystem August 1, 2025 15:05
@AdamTadeusz AdamTadeusz marked this pull request as draft August 1, 2025 18:55
@AdamTadeusz AdamTadeusz changed the title 260 background map option readable Background map option readable Aug 4, 2025
@AdamTadeusz AdamTadeusz marked this pull request as ready for review August 4, 2025 18:10
@Rainyan Rainyan requested review from Rainyan and removed request for a team August 14, 2025 19:00
@AdamTadeusz AdamTadeusz requested a review from Rainyan August 15, 2025 13:09
@DESTROYGIRL DESTROYGIRL added the Conflict conflicts with master label Aug 17, 2025
@AdamTadeusz AdamTadeusz removed the Conflict conflicts with master label Aug 18, 2025
@Rainyan
Copy link
Collaborator

Rainyan commented Aug 27, 2025

@AdamTadeusz Is this PR ready for re-review?

@AdamTadeusz
Copy link
Contributor Author

I can see I accidentally changed the default background but other than that yes. I should probably gitignore that file now that its generated automatically

@Rainyan Rainyan self-requested a review August 27, 2025 13:29
@AdamTadeusz
Copy link
Contributor Author

Now I'm confused because it is in .gitignore already, maybe it only takes effect once its merged in?

@Rainyan
Copy link
Collaborator

Rainyan commented Aug 27, 2025

Now I'm confused because it is in .gitignore already, maybe it only takes effect once its merged in?

That's strange (.gitignore is supposed to take effect immeditately). Well, I'll just proceed with this review for now but we should probably investigate this. Could be some kind of a strange syntax issue?

.gitignore is also case-sensitive so that's worth double-checking. (Edit: not quite true; please see discussion below...)

@Rainyan
Copy link
Collaborator

Rainyan commented Aug 27, 2025

@AdamTadeusz Is there a chance your version of ChapterBackgrounds.txt doesn't follow what exact capitalization in the gitignore? As a follow-up on the gitignore problem.

This might not show up on the OS filesystem if you're using Windows, since it (NTFS) is not aware of filename casing at all.

@AdamTadeusz
Copy link
Contributor Author

AdamTadeusz commented Aug 27, 2025

@AdamTadeusz Is there a chance your version of ChapterBackgrounds.txt doesn't follow what exact capitalization in the gitignore? As a follow-up on the gitignore problem.

image

Its in camelcase on my end like in the gitignore

(Edit) PascalCase actually

@Rainyan
Copy link
Collaborator

Rainyan commented Aug 27, 2025

Actually I misspoke, it seems it depends on git config core.ignorecase rather than the platform FS. I don't quite know off the top of my head whether this is portable for Linux/Win development.

@Rainyan
Copy link
Collaborator

Rainyan commented Aug 27, 2025

@AdamTadeusz Is there a chance your version of ChapterBackgrounds.txt doesn't follow what exact capitalization in the gitignore? As a follow-up on the gitignore problem.

image Its in camelcase on my end like in the gitignore

Hmm, very strange. Thanks for following up on it though.

I guess this is becoming somewhat offtopic for this PR so I'll leave it at that, but if we re-encounter this problem in the future, then it's probably worth raising a bug ticket for, so that we can figure out the root cause.

Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that when looking at the menu, the names of the maps are more readable than the integer numbers that were previously there in other builds. Also changed the background map, and checked that the associated map is loaded after restarting the game.

@AdamTadeusz AdamTadeusz merged commit f821c8e into NeotokyoRebuild:master Aug 28, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 260_backgroundMapOptionReadable branch August 28, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants