NeoUI - Refactor + add vertical per row-cell layout #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunzenshen
reviewed
Jul 27, 2025
sunzenshen
reviewed
Jul 27, 2025
AdamTadeusz
previously approved these changes
Jul 28, 2025
Contributor
|
maybe this would be a good pr to fix #1246 |
* Refactor layouting related section mostly so it's more workable with the vertical layouting and more clear start-end point during alterting the layouting * New vertical per row-cell layouting which allows multiple sub-rows used, mostly for label-only decorated visuals * Split off from the WIP killer damage HUD and only benefits that PR for now * Fix overlapping highlighting issue * fixes NeotokyoRebuild#1246
nullsystem
force-pushed
the
NeoUIRefactVert
branch
from
44f35ed to
20bbe86
Compare
Collaborator
Author
|
Added sanity checks + asserts for |
sunzenshen
approved these changes
Jul 29, 2025
AdamTadeusz
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xWidechange from multiple ternary to if statements for clearer readabilityToolchain
Linked Issues