Skip to content

Conversation

@nullsystem
Copy link
Collaborator

This reverts commit aa58c4a. Because there's issues with mouse focus screwing with the other dialogs, just reverting this should fix that one and instead the -tools option will load up the legacy main menu instead.

@Rainyan Rainyan self-requested a review July 25, 2025 18:28
Rainyan
Rainyan previously approved these changes Jul 26, 2025
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rainyan Rainyan requested a review from a team July 26, 2025 22:50
sunzenshen
sunzenshen previously approved these changes Jul 26, 2025
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the game to crash on startup for me when running with -tools. I can see the engine tools window appear, so maybe its caused by trying to load up the legacy menus?
(im on windows)

Edit: #1232 (comment)

@Rainyan
Copy link
Collaborator

Rainyan commented Jul 27, 2025

This causes the game to crash on startup for me when running with -tools. I can see the engine tools window appear, so maybe its caused by trying to load up the legacy menus? (im on windows)

@DESTROYGIRL Hmm, I can't reproduce this on Windows 11. Launch options: -allowdebug -insecure -dev -sw -toconsole -tools -game "I:\code\neo\game\neo"

@nullsystem
Copy link
Collaborator Author

@DESTROYGIRL Same with rain, I wasn't able to reproduce the crash either

I've set this C:\Program Files (x86)\Steam\steamapps\common\Source SDK Base 2013 Multiplayer\bin\x64\sdkenginetools.txt at seemed to have loaded the tools without crash:

"enginetools"
{
	"library"	"../tools/x64/actbusy.dll"
	"library"	"../tools/x64/commedit.dll"
	"library"	"../tools/x64/gameevents.dll"
	"library"	"../tools/x64/pet.dll"
	"library"	"../tools/x64/sampletool.dll"
	"library"	"../tools/x64/vcdblock.dll"
	"library"	"../tools/x64/vmt.dll"
}

Launch args: -allowdebug -insecure -dev -sw -game C:\dev\git\neo\game\neo -tools -nop4

@DESTROYGIRL
Copy link
Contributor

@DESTROYGIRL Hmm, I can't reproduce this on Windows 11. Launch options: -allowdebug -insecure -dev -sw -toconsole -tools -game "I:\code\neo\game\neo"

Admittedly I do have some issues using -tools speaking outside this PR, it's totally non-functional for me on the sourcemod version but seems to work on the steam version, despite me having copied the DLLs correctly.
So it could be that I'm missing some change in a resource file or something that breaks the legacy menu, I don't know. I'll look into it further

@DESTROYGIRL
Copy link
Contributor

Admittedly I do have some issues using -tools speaking outside this PR, it's totally non-functional for me on the sourcemod version but seems to work on the steam version,

I didn't realise -allowdebug was required for it to work on the SM version but okay. Despite getting that to work, still getting a crash after verifying integrity & making sure everything is up to date with master. Going to try the debugger...

@DESTROYGIRL
Copy link
Contributor

It's caused by my game trying to load the background map, and trying to load any map when the game is running -tools will cause a crash.

Press F10, open console, and try loading a map

@nullsystem nullsystem dismissed stale reviews from sunzenshen and Rainyan via 528d632 July 27, 2025 11:51
@nullsystem
Copy link
Collaborator Author

@DESTROYGIRL Forgotten about the NeoUI loading screen, try it now, the loading should be back to legacy on -tools and map loading works.

@nullsystem nullsystem added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Jul 27, 2025
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to have fixed the issue thanks.

@nullsystem nullsystem merged commit 0658b63 into NeotokyoRebuild:master Jul 27, 2025
7 checks passed
@sunzenshen sunzenshen removed their request for review July 27, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants