Code cleanup #1219
Merged
Code cleanup #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamTadeusz
previously approved these changes
Jul 23, 2025
Because this runs really often
Silence some debug assertions that trigger for the tutorial map, related to the outro sequence with the dangling VR helmet prop.
Gather the dummy bots in a C_EntityClassList so that we can decouple their counting from the gamerules entity.
Collaborator
Author
|
Rebased to master to fix a merge conflict. |
Masterkatze
approved these changes
Jul 23, 2025
AdamTadeusz
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some cleanup of the code base.
Removed the old unused teammate position vectors that were cluttering up the player send/receive tables.
Refactored the way dummy positions are networked to client, so they're not coupled to the gamerules entity.
Converted dynamic_casts to static_casts in player & HUD classes where possible, for performance.
Silenced some debug asserts spam for the tutorial map.
Toolchain
Linked Issues