Skip to content

Spray handling improvements - Freezetime, disabled spray, cleanups #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nullsystem merged 1 commit into from
Jul 19, 2025
Merged

Spray handling improvements - Freezetime, disabled spray, cleanups #1218

nullsystem merged 1 commit into from
Jul 19, 2025

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 12, 2025 •
edited
Loading

Description

  • Allow impulse 201 (spray) in freezetime
  • Prevent impulse 201 if the client disabled spray
  • Delete custom downloaded sprays on both startup and shutdown
    • Both startup and shutdown mostly to workaround filesystem API bug trying to recognize some of the files
  • Test on *.dat sprays deletion on Windows (rainyan tested)

Toolchain

  • Linux GCC Distro Native Gentoo/GCC 14

Linked Issues

@nullsystem nullsystem marked this pull request as ready for review July 12, 2025 13:33
@nullsystem nullsystem marked this pull request as draft July 12, 2025 13:35
@nullsystem nullsystem force-pushed the GH-1205_SprayImpulse branch 2 times, most recently from 0cb2346 to b8e4b10 Compare July 12, 2025 14:24
@nullsystem nullsystem marked this pull request as ready for review July 12, 2025 14:24
@nullsystem nullsystem force-pushed the GH-1205_SprayImpulse branch from b8e4b10 to 2e27e3b Compare July 12, 2025 14:37
@nullsystem nullsystem changed the title Spray handling improvements - Freezetime, disabled spray, shutdown Spray handling improvements - Freezetime, disabled spray, init/deinit Jul 12, 2025
@nullsystem nullsystem requested a review from a team July 12, 2025 14:39
@nullsystem nullsystem changed the title Spray handling improvements - Freezetime, disabled spray, init/deinit Spray handling improvements - Freezetime, disabled spray, cleanups Jul 12, 2025
Rainyan
Rainyan reviewed Jul 12, 2025
View reviewed changes
@nullsystem
Spray handling improvements - Freezetime, disabled spray, shutdown
2a11542 
* Allow impulse 201 (spray) in freezetime
* Prevent impulse 201 if the client disabled spray
* Delete custom downloaded sprays on both startup and
  shutdown. Both mostly due to workaround filesystem API
  bug.
* Also delete the 2-hex directories if they're empty
* fixes NeotokyoRebuild#1205
@nullsystem nullsystem force-pushed the GH-1205_SprayImpulse branch from 2e27e3b to 2a11542 Compare July 12, 2025 19:27
@nullsystem nullsystem requested a review from Rainyan July 12, 2025 22:03
@nullsystem nullsystem added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Jul 12, 2025
@nullsystem nullsystem requested a review from a team July 12, 2025 22:05
@Rainyan Rainyan requested a review from a team July 13, 2025 14:40
@nullsystem nullsystem merged commit 9138316 into NeotokyoRebuild:master Jul 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Masterkatze Masterkatze Masterkatze approved these changes

@Rainyan Rainyan Rainyan approved these changes

Assignees

No one assigned

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Players cannot use sprays during pre-round freezetime

3 participants

@nullsystem @Masterkatze @Rainyan