Add neo_restart_this support #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the neo_restart_this cvar for parity. This cvar differs from mp_restartgame in that the latter will give a countdown whereas neo_restart_this is instant.
Rainyan
force-pushed
the
bug/neo-restart-this
branch
from
b4770cc to
9f3ae20
Compare
Contributor
|
Most definitely unrelated, but restarting a bunch before the round started gave me this error 
|
Contributor
|
Can't come up with a good way to replicate it it seems very random |
AdamTadeusz
approved these changes
Jul 23, 2025
Contributor
AdamTadeusz
left a comment
AdamTadeusz
left a comment
There was a problem hiding this comment.
We know this is an issue already that needs fixing so approving anyway
Collaborator
Author
Very interesting. I'll try and replicate too, later. Probably unrelated to this PR as you said but would be nice to fix at some point for good. |
sunzenshen
approved these changes
Jul 25, 2025
Contributor
sunzenshen
left a comment
sunzenshen
left a comment
There was a problem hiding this comment.
LGTM. If anything, the real issue needs to be debugged from RestartGame() if that was related to the bug, rather than from this wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
neo_restart_thiscvar for parity.This cvar differs from
mp_restartgamein that the latter will give a countdown, whereasneo_restart_thisis instant.As a side note, the cvar
mp_restartgame_immediateseen below isCTeamplayRoundBasedRulesrelated, which is not part of our gamerules inheritance chain, and its logic is not quite right, so that's why I'm rolling my own callback for the cvar.Toolchain
Linked Issues