Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

Description

Not sure if I'm happy with this to be honest, loading the db file loads every single song that was ever played or loaded as a playlist through the mp3 player, perhaps it would make more sense to remove this db functionality altogether. I guess we can open another PR to remove this properly, but it might still be a good idea to have a commit on master where it was working.

Linked Issues

@AdamTadeusz AdamTadeusz requested a review from a team July 8, 2025 10:52
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UX could brush-up for sure, it's very confusing to navigate. Some items you have to right click but there's no context hint about it etc. And I'm not gonna pretend I understand how these playlists are supposed to be used. But it's good to get this playlist saving logic in as you said, for future iteration.

@Rainyan Rainyan requested a review from a team July 13, 2025 13:33
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, after monkeying around with the player settings, I'm seeing staged files in git:

On branch 250_mp3Database
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   game/neo/resource/mp3settings.txt
        modified:   game/neo/sound/playlist/soundtrack.txt

Maybe we should gitignore these, so that devs don't accidentally push their Spice Girls playlist upstream.

...or can we even sensibly ignore tracked file changes? More trouble than it's worth(?)

@AdamTadeusz
Copy link
Contributor Author

AdamTadeusz commented Jul 13, 2025

Saving playlists should work already without this PR, I guess the db is for loading music that's expected to be played soon, but the way it works right now it will just load every single song from every playlist you've loaded so I'm not sure its the best feature, which is why I suggested removing it once we have a commit on master where it's working properly.

We want an initial settings file since it holds the current playlist without which the player will not play anything on game load, but ignoring any txt file in this folder from here on out is probably a good idea?

@Rainyan Rainyan requested a review from a team July 13, 2025 13:56
@AdamTadeusz AdamTadeusz merged commit 0e8d9ec into NeotokyoRebuild:master Jul 23, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 250_mp3Database branch July 23, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

restore MP3 db saving functionality

3 participants