Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

No description provided.

Rainyan
Rainyan previously approved these changes Jul 5, 2025
@Rainyan Rainyan requested a review from a team July 5, 2025 15:10
@AdamTadeusz AdamTadeusz marked this pull request as draft July 5, 2025 17:27
@sunzenshen sunzenshen requested review from a team and removed request for a team July 27, 2025 20:00
@AdamTadeusz
Copy link
Contributor Author

AdamTadeusz commented Sep 9, 2025

I think I was gonna make a version of SUB_Vanish that excluded bots, but with bot takeover maybe thats not such a good idea, also on maps like bullet where this is most needed there's almost always someone in range of most dropped weapons so they end up pilling up anyway, decided to just revert to the old fade and remove functions for gibs and weapons respectively, saves us doing hundreds of for loops through all the players at a rate of 10Hz as a match of ntre_bullet_tdm progresses

@AdamTadeusz AdamTadeusz marked this pull request as ready for review September 9, 2025 11:55
Rainyan
Rainyan previously approved these changes Sep 9, 2025
@Rainyan Rainyan requested a review from a team September 9, 2025 12:26
@sunzenshen
Copy link
Contributor

I think I was gonna make a version of SUB_Vanish that excluded bots, but with bot takeover maybe thats not such a good idea

For what it's worth, on maps with respawns, with the proposed implementation of bot takeovers, you might not need to worry about bot takeovers as you need to be on the same team. That means spectators cannot just jump into any bot (this simplifies the logic for many situations). When you are on a team, spawns seem to be forced so you don't go into spectate mode, and thus don't need to worry about bot takeovers.

Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gibs fade out, but ragdolls don't, they just pop out of existance

@AdamTadeusz
Copy link
Contributor Author

Yup I haven't touched the ragdolls, currently they dissapear after the owner dies again

@AdamTadeusz AdamTadeusz merged commit 4b1aa3d into NeotokyoRebuild:master Sep 19, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 246_removeWeaponsGibsOnMapsWithRespawns branch September 19, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants