-
Notifications
You must be signed in to change notification settings - Fork 20
Networked crosshair #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networked crosshair #1188
Conversation
103157d to
a775fdf
Compare
a775fdf to
8085d6d
Compare
8085d6d to
e98a36f
Compare
|
maybe instead of doing all those InstallChangeCallback s, pass the function as a parameter in the convar definition |
Rainyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on LAN, seems to work well. But left some language nits that we might wanna fix before merging.
e98a36f to
6df1f62
Compare
|
@AdamTadeusz This prevents any convar that EX: uses float 0.0 to 1.0 (min + max) from being able to use properly, cause now it's only stored as "0" or "1" but |
|
I assumed ChangeStringValue was only used for chars, but that's an easy fix |
|
could also add FCVAR_NEVER_AS_STRING to every single float and int convar just in case (this is a joke) |
|
Can't really be sure non-open part of SDK will always utilize |
* Since the change to string-based serialization is applied, it's now more straightforward to implement networked crosshair * The networking is similar to how it's done for `neo_name` and `neo_clantag` as it's just strings passed around * `cl_neo_crosshair_network` 0 = disable viewing other players crosshair, 1 = show other players crosshair * "Other players crosshair" meaning when you're spectating the other person in 1st person while they ADS * NeoUI settings - Slight alterations, added set to default button but also crosshair no longer part of the full-on reset button, so like the volume setting won't reset on full-on settings reset * NeoUI settings - Added toggle for viewing networked crosshair * NeoUI settings - Export/Import(/Default) buttons no longer restricted to only custom * Improved default crosshair * fixes NeotokyoRebuild#1187
6df1f62 to
f186e93
Compare



Description
neo_nameandneo_clantagas it's just strings passed aroundcl_neo_crosshair_network0 = disable viewing other players crosshair, 1 = show other players crosshairToolchain
Linked Issues