Skip to content

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jun 7, 2025

Description

  • All crosshair convars now converge into just cl_neo_crosshair
  • String based serialization instead of file
  • Copy/paste crosshair import/export functionality

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native Gentoo/GCC 14.2.1

Linked Issues

* All crosshair convars now converge into just `cl_neo_crosshair`
* String based serialization instead of file
* Copy/paste crosshair import/export functionality

* fixes NeotokyoRebuild#1180
@nullsystem nullsystem force-pushed the GH-1180_CrosshairStringSerialization branch from 26a3e99 to 232a559 Compare June 7, 2025 13:22
@nullsystem nullsystem changed the title [WIP] Crosshair - Change to single string convar + serialzation Crosshair - Change to single string convar + serialzation Jun 7, 2025
@nullsystem nullsystem marked this pull request as ready for review June 7, 2025 13:22
@nullsystem nullsystem changed the title Crosshair - Change to single string convar + serialzation Crosshair - Change to single string convar + serialization Jun 7, 2025
@nullsystem nullsystem requested a review from a team June 7, 2025 13:59
@nullsystem nullsystem force-pushed the GH-1180_CrosshairStringSerialization branch from 083af68 to 880787d Compare June 7, 2025 20:15
* The clipboard API on Windows somewhat returns UTF-16 arranged bytes
  for char *, so instead just use wchar_t * and convert it to char *
  before passing it to ImportCrosshair
* fixes NeotokyoRebuild#1180
@nullsystem nullsystem force-pushed the GH-1180_CrosshairStringSerialization branch from 880787d to f421ca0 Compare June 7, 2025 20:16
@nullsystem nullsystem requested a review from Rainyan June 7, 2025 20:22
@Rainyan Rainyan requested a review from a team June 7, 2025 20:31
@AdamTadeusz
Copy link
Contributor

unrelated but I cannot select the last input on any settings page to drag it or change the value with keyboard input

@nullsystem nullsystem merged commit 2178154 into NeotokyoRebuild:master Jun 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change custom crosshair serialization to single convar string instead of multiple convar + files

3 participants