Skip to content

fix loading ui crash getting an non valid adress for UText #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nbc66 wants to merge 1 commit into from
Closed

fix loading ui crash getting an non valid adress for UText #1174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/game/client/neo/ui/neo_loading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ void CNeoLoading::OnMainLoop(const NeoUI::Mode eMode)
NeoUI::BeginSection(true);
{
NeoUI::Label(L"Press ESC to cancel");
if (m_pLabelInfo) NeoUI::Label(m_pLabelInfo->GetTextImage()->GetUText());
if (m_pLabelInfo) //NeoUI::Label(m_pLabelInfo->GetTextImage()->GetUText());
Copy link
Collaborator

@nullsystem nullsystem Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this will cause it to if over the next line and no one else seem to have this issue so I wouldnt completely cut it out? You altered the loading dialog UI/res file, localization difference, or something? At most can just expand the if statement to check more pointers.

Copy link
Contributor Author

@Nbc66 Nbc66 Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the thing i would recomend is just get the uText at the beginning when you cast it to a label there is no other way of doing this also I haven't touched a single resfile for this. this only happens cause the pointer becomes invalid after moving out of the scope when casting the pointer and the pointer becoming corupted

Copy link
Collaborator

@nullsystem nullsystem Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure if the text gets properly updated on each onmessage activate. You could also try to nullptr out the panel pointers on deactivate and just before refetching panels to see if it helps somewhat

if (m_pProgressBarMain) NeoUI::Progress(m_pProgressBarMain->GetProgress(), 0.0f, 1.0f);
}
NeoUI::EndSection();
Expand Down