-
Notifications
You must be signed in to change notification settings - Fork 20
Player pings #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player pings #1125
Conversation
…r ping sometimes not precaching
brysondev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; need to test UHD resolutions and networked sounds.
|
Missing ping material, also scale is a little small on 4K |
brysondev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
figured out the problem with the sound handle, turned out I was editing the game_sounds_ui text file from the original. Also added a message when someone pings a location (can be toggled off), so you can work out who to mute if someone is pinging way too often |
|
@AdamTadeusz What's the current status of this design doc, has this been approved for merge? |
|
I don't really know who approves these design docs. I think I've addressed the concerns people have as best as I could. |
sunzenshen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we would need to test this in multiplayer to see how this goes, but this works on my machine in an empty server. Maybe this could be hidden behind a feature flag if people aren't sure about it.
|
Probably should be rebased to resolve merge conflicts with master branch. |
|
Too many commits to rebase in my opinion, merge+squash should be fine as discussed? |
sunzenshen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Description
Allows players to share a location with teammates
NeoAssets PR
Discord post
Google Doc