Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented May 6, 2025

Description

Allows players to share a location with teammates

NeoAssets PR

Discord post

Google Doc

@AdamTadeusz AdamTadeusz added Enhancement New feature or request Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description labels May 6, 2025
@AdamTadeusz AdamTadeusz requested a review from a team May 6, 2025 14:14
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; need to test UHD resolutions and networked sounds.

@brysondev
Copy link
Contributor

Missing ping material, also scale is a little small on 4K

@AdamTadeusz AdamTadeusz requested a review from brysondev May 11, 2025 15:30
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@AdamTadeusz
Copy link
Contributor Author

figured out the problem with the sound handle, turned out I was editing the game_sounds_ui text file from the original. Also added a message when someone pings a location (can be toggled off), so you can work out who to mute if someone is pinging way too often

@AdamTadeusz AdamTadeusz requested a review from a team July 24, 2025 11:00
@Rainyan
Copy link
Collaborator

Rainyan commented Jul 24, 2025

@AdamTadeusz What's the current status of this design doc, has this been approved for merge?

@AdamTadeusz
Copy link
Contributor Author

I don't really know who approves these design docs. I think I've addressed the concerns people have as best as I could.

sunzenshen
sunzenshen previously approved these changes Jul 27, 2025
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we would need to test this in multiplayer to see how this goes, but this works on my machine in an empty server. Maybe this could be hidden behind a feature flag if people aren't sure about it.

@sunzenshen sunzenshen requested a review from a team July 27, 2025 20:05
@Rainyan Rainyan requested review from Rainyan and removed request for a team August 1, 2025 11:45
@AdamTadeusz AdamTadeusz requested a review from Rainyan August 11, 2025 21:16
@sunzenshen
Copy link
Contributor

Probably should be rebased to resolve merge conflicts with master branch.

@AdamTadeusz
Copy link
Contributor Author

Too many commits to rebase in my opinion, merge+squash should be fine as discussed?

@Rainyan Rainyan requested a review from sunzenshen August 27, 2025 11:48
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping_okay

@AdamTadeusz AdamTadeusz merged commit cbab724 into NeotokyoRebuild:master Aug 28, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 218_playerPings branch August 28, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants