Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Apr 22, 2025

Description

Holding the walk button ensures quiet walking below a raised threshold

Discord discussion

Change document

Linked Issues

@AdamTadeusz AdamTadeusz added the Enhancement New feature or request label Apr 22, 2025
@AdamTadeusz AdamTadeusz marked this pull request as draft April 22, 2025 12:22
@AdamTadeusz AdamTadeusz marked this pull request as ready for review May 17, 2025 15:58
@AdamTadeusz
Copy link
Contributor Author

I made walking limit the speed at least to what the speed would have to be for the player to walk silently in that stance, this also means that pressing the walk button when already below the noise threshold doesn't have any effect (not sure if there are any situations where that may be the case).

I also added a little something extra. There is a run threshold of 220, any footsteps above this threshold result in louder footsteps. Since the speed of a sprinting assault with a minimal encumbrance weapon such as the srm results in a speed of ~216 (and even lower with higher encumbrance weapons), assaults would be making normal sounding footsteps when running unless turning the mouse or changing direction. In the spirit of making the player controls control the sound the player makes more consistently, I made the prerequisite for making quieter but still audible footsteps both to have a speed below 220 and also to not be sprinting.

@AdamTadeusz AdamTadeusz requested a review from a team May 17, 2025 16:07
Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using some heavy primaries as support, they move so slowly that they don't produce footsteps when walking normally now. Try supa7, PZ

@AdamTadeusz
Copy link
Contributor Author

When using some heavy primaries as support, they move so slowly that they don't produce footsteps when walking normally now. Try supa7, PZ

I networked m_fIsWalking for this exact purpose and forgot to use it xD

Copy link
Contributor

@DESTROYGIRL DESTROYGIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everyone is in agreement that this is a good change so

Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. If anything, silent walking could be balanced in other ways if players find it too weird that Support is too quiet.

@AdamTadeusz AdamTadeusz merged commit 0937dec into NeotokyoRebuild:master Jul 31, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 208_silentWalking branch July 31, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] UI element for walking

4 participants