Supa reload while sprinting, toggling gamecontrolui menus off sometimes not working, class selection menu still toggling on in spectate and xp given to spectators on round draw

[AdamTadeusz]

Description

Some minor fixes

Previously it was possible to initiate a supa 7 reload while sprinting, it was impossible to toggle the team class loadout menus off if the console was not opened previously, a silly mistake meant the previous fix to not toggle the class selection menu when spectating was not working, and a check to make sure spectators do not receive score on round draw

Toolchain

• Windows MSVC VS2022
• Linux GCC Distro Native [Specify distro + GCC version]
• Linux GCC 10 Sniper 3.0

Linked Issues

• fixes Supa 7 can initiate reload while sprinting #1091
• fixes spectators get one xp on round draw #1090
• fixes Leaving a team and then joining spectator prompts the player with the class selection menu #1043

[AdamTadeusz]

should figure out how to precache those keys on settings save too

[AdamTadeusz]

should figure out how to precache those keys on settings save too

or maybe not

[AdamTadeusz]

When I added the mp3 player I initially wanted the key bind that toggles it to work both in game and in the menu. As of the time of writing this comment this doesn't actually work in the menus on this branch as I removed the GetButtonCodeForBind in neo_root.cpp, therefore bcMP3Player always has the default value of KEY_NONE

@nullsystem rightfully pointed out that previously when bcMP3Player was set to the keybind correctly, it made the mp3 player pop up in the menus when pressing the neo_mp3 bind when inputting text into fields for example, so this branch will continue to fix that bug as well.

I'm gonna merge master and add a commit to remove all other references to bcMP3Player, and will for now be content with the keybind for neo_mp3 only working to close the mp3 player when it is in focus when in the main menu.

I should note that the bug @nullsystem pointed out also is present when the console key is pressed when a text field is in focus, toggling the console on and off when trying to enter a tilde (or whatever the console is bound to) into a text field. Once this problem is fixed perhaps the neo_mp3 keybind can benefit from it to make the mp3player keybind open the player in the main menu again when the user isn't entering text into a field

[sunzenshen]

Verified that the Supa reload cannot be initiated while actively sprinting. That said, is it expected to drain Aux when holding down +sprint while the Supa is actively reloading?

[AdamTadeusz]

Verified that the Supa reload cannot be initiated while actively sprinting. That said, is it expected to drain Aux when holding down +sprint while the Supa is actively reloading?

You are only prevented from initiating a reload while sprinting in the original, initiating a sprint after beginning a reload should allow the character to sprint, drain their aux, and continue reloading their weapon. Is this the behavior you are referring to?

[AdamTadeusz]

runningReload.mp4

Tbh with a clever config you can basically achieve a running reload in og, maybe in rebuild too but haven't tried it yet

[sunzenshen]

Verified that the Supa reload cannot be initiated while actively sprinting. That said, is it expected to drain Aux when holding down +sprint while the Supa is actively reloading?

You are only prevented from initiating a reload while sprinting in the original, initiating a sprint after beginning a reload should allow the character to sprint, drain their aux, and continue reloading their weapon. Is this the behavior you are referring to?

Ah, okay, sounds like parity to me then. 👍